From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Date: Mon, 12 Oct 2015 08:56:16 +0000 Subject: Re: [PATCH] sh: add copy_user_page() alias for __copy_user() Message-Id: <20151012085616.GA2579@codeblueprint.co.uk> List-Id: References: <1442958411-4271-1-git-send-email-ross.zwisler@linux.intel.com> <20151008230734.GB19399@linux.intel.com> In-Reply-To: <20151008230734.GB19399@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Ross Zwisler , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Geert Uytterhoeven , Andy Shevchenko , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Andrew Morton On Thu, 08 Oct, at 05:07:34PM, Ross Zwisler wrote: > On Tue, Sep 22, 2015 at 03:46:51PM -0600, Ross Zwisler wrote: > > copy_user_page() is needed by DAX. Without this we get a compile error > > for DAX on SH: > > > > fs/dax.c:280:2: error: implicit declaration of function ‘copy_user_page’ > > [-Werror=implicit-function-declaration] > > copy_user_page(vto, (void __force *)vfrom, vaddr, to); > > ^ > > > > This was done with a random config that happened to include DAX support. > > > > This patch has only been compile tested. > > > > Signed-off-by: Ross Zwisler > > Reported-by: Geert Uytterhoeven > > --- > > Apologies for the resend, I wanted to add some more recipients. > > --- > > arch/sh/include/asm/page.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/sh/include/asm/page.h b/arch/sh/include/asm/page.h > > index fe20d14..ceb5201 100644 > > --- a/arch/sh/include/asm/page.h > > +++ b/arch/sh/include/asm/page.h > > @@ -59,6 +59,7 @@ pages_do_alias(unsigned long addr1, unsigned long addr2) > > > > #define clear_page(page) memset((void *)(page), 0, PAGE_SIZE) > > extern void copy_page(void *to, void *from); > > +#define copy_user_page(to, from, vaddr, pg) __copy_user(to, from, PAGE_SIZE) > > > > struct page; > > struct vm_area_struct; > > Ping? Your best bet is probably to Cc Andrew (now Cc'd). Andrew, original patch is here, https://lkml.kernel.org/r/1442958411-4271-1-git-send-email-ross.zwisler@linux.intel.com -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH] sh: add copy_user_page() alias for __copy_user() Date: Mon, 12 Oct 2015 09:56:16 +0100 Message-ID: <20151012085616.GA2579@codeblueprint.co.uk> References: <1442958411-4271-1-git-send-email-ross.zwisler@linux.intel.com> <20151008230734.GB19399@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton To: Ross Zwisler , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Geert Uytterhoeven , Andy Shevchenko , Matthew Wilcox , linux-fsdevel@vger.kernel.org Return-path: Content-Disposition: inline In-Reply-To: <20151008230734.GB19399@linux.intel.com> Sender: linux-sh-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 08 Oct, at 05:07:34PM, Ross Zwisler wrote: > On Tue, Sep 22, 2015 at 03:46:51PM -0600, Ross Zwisler wrote: > > copy_user_page() is needed by DAX. Without this we get a compile e= rror > > for DAX on SH: > >=20 > > fs/dax.c:280:2: error: implicit declaration of function =E2=80=98co= py_user_page=E2=80=99 > > [-Werror=3Dimplicit-function-declaration] > > copy_user_page(vto, (void __force *)vfrom, vaddr, to); > > ^ > >=20 > > This was done with a random config that happened to include DAX sup= port. > >=20 > > This patch has only been compile tested. > >=20 > > Signed-off-by: Ross Zwisler > > Reported-by: Geert Uytterhoeven > > --- > > Apologies for the resend, I wanted to add some more recipients. > > --- > > arch/sh/include/asm/page.h | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/arch/sh/include/asm/page.h b/arch/sh/include/asm/page.= h > > index fe20d14..ceb5201 100644 > > --- a/arch/sh/include/asm/page.h > > +++ b/arch/sh/include/asm/page.h > > @@ -59,6 +59,7 @@ pages_do_alias(unsigned long addr1, unsigned long= addr2) > > =20 > > #define clear_page(page) memset((void *)(page), 0, PAGE_SIZE) > > extern void copy_page(void *to, void *from); > > +#define copy_user_page(to, from, vaddr, pg) __copy_user(to, from,= PAGE_SIZE) > > =20 > > struct page; > > struct vm_area_struct; >=20 > Ping? Your best bet is probably to Cc Andrew (now Cc'd). Andrew, original patch is here, https://lkml.kernel.org/r/1442958411-4271-1-git-send-email-ross.zwisl= er@linux.intel.com --=20 Matt Fleming, Intel Open Source Technology Center