Re: [PATCH 1/3] docs: dts: Add documentation for hi6220 SoC ION node

[Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>]

On Mon, Oct 12, 2015 at 02:46:24PM +0800, Chen Feng wrote:
> Documentation for hi6220 SoC ION node
> 
> Signed-off-by: Chen Feng <puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
> Signed-off-by: Yu Dongbin <yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
> ---
>  .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt


We should not be adding platform-specific bindings and/or drivers for
this.

There's already a proposal for a generic binding [1]. Please work with
that rather than working on your own.

Mark.

[1] https://lkml.org/lkml/2015/10/6/854
 
> diff --git a/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt
> new file mode 100644
> index 0000000..c59e27c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt
> @@ -0,0 +1,31 @@
> +Hi6220 SoC ION
> +===================================================================
> +Required properties:
> +- compatible : "hisilicon,hi6220-ion"
> +- list of the ION heaps
> +	- heap name : maybe heap_sys_user@0
> +	- heap id   : id should be unique in the system.
> +	- heap base : base ddr address of the heap,0 means that
> +	it is dynamic.
> +	- heap size : memory size and 0 means it is dynamic.
> +	- heap type : the heap type of the heap, please also
> +	see the define in ion.h(drivers/staging/android/uapi/ion.h)
> +-------------------------------------------------------------------
> +Example:
> +	hi6220-ion {
> +		compatible = "hisilicon,hi6220-ion";
> +		heap_sys_user@0 {
> +			heap-name = "sys_user";
> +			heap-id   = <0x0>;
> +			heap-base = <0x0>;
> +			heap-size = <0x0>;
> +			heap-type = "ion_system";
> +		};
> +		heap_sys_contig@0 {
> +			heap-name = "sys_contig";
> +			heap-id   = <0x1>;
> +			heap-base = <0x0>;
> +			heap-size = <0x0>;
> +			heap-type = "ion_system_contig";
> +		};
> +	};
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html