Re: [Outreachy kernel] [PATCH] staging: gdmwm: move constant to right side of comparison test

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Sun, Oct 11, 2015 at 12:04:22PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 10 Oct 2015, Alison Schofield wrote:
> 
> > On Sat, Oct 10, 2015 at 09:22:27AM +0200, Julia Lawall wrote:
> > > On Sat, 10 Oct 2015, Sudip Mukherjee wrote:
> > > 
> > > > On Thu, Oct 08, 2015 at 11:13:23PM -0700, Alison Schofield wrote:
<snip>
> > > 
> > > I'm not sure there is such a semantic intent to the rule.  Do something 
> > > complex and then see if it is like T, looks better to me than see if T is 
> > > like doing something complex.  The checkpatch/commit message is indeed 
> > > misleading, but the layout of characters looks better.
> > > 
> > > julia
> > 
> > Let me see if I have the correct understanding.
> > 
> > T and L are variables, not constants, therefore the checkpatch error and
> > my subsequent commit msg are misleading. 
> 
> Yes.
> 
> > Regardless of whether this
> > case should have been flagged by checkpatch the edit improves
> > readability.
> > 
> > So, I'd lean towards keeping the edit and changing the commit msg & 
> > description like this:
> > 
> > 	staging: gdmwm: move variable to right side of comparison test
> >     
> > 	Move variables to right side of comparison test to improve readability.
> > 		
> > Your thoughts?
> 
> It seems good to me.

Sorry for the late reply. Commit message looks good now.

regards
sudip