From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zldwu-0007IK-VU for mharc-grub-devel@gnu.org; Mon, 12 Oct 2015 10:19:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZldwY-00071q-6H for grub-devel@gnu.org; Mon, 12 Oct 2015 10:19:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZldwX-00014h-A7 for grub-devel@gnu.org; Mon, 12 Oct 2015 10:19:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZldwX-00012O-3T for grub-devel@gnu.org; Mon, 12 Oct 2015 10:19:13 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 31AFAC0C1B0D for ; Mon, 12 Oct 2015 14:19:12 +0000 (UTC) Received: from redhat.com (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9CEJ9LY014023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 12 Oct 2015 10:19:11 -0400 Date: Mon, 12 Oct 2015 10:19:09 -0400 From: Peter Jones To: The development of GNU GRUB Subject: Re: [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5). Message-ID: <20151012141909.GA19125@redhat.com> References: <1393366348-22020-1-git-send-email-pjones@redhat.com> <56195D9A.2010306@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56195D9A.2010306@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 14:19:15 -0000 On Sat, Oct 10, 2015 at 09:48:58PM +0300, Andrei Borzenkov wrote: > 26.02.2014 02:12, Peter Jones =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >This is version 4. > > > >Changes from version 1: > >- handles SHIFT as a modifier > >- handles F11 and F12 keys > >- uses the handle provided by the system table to find our _EX protoco= l. > > > >Changes from version 2: > >- eliminate duplicate keycode translation. > > > >Changes from version 3: > >- Do not add the shift modifier for any ascii character between space > > (0x20) and DEL (0x7f); the combination of the modifier and many of = the > > keys causes it not to be recognized at all. Specifically, if we > > include the modifier on any querty punctuation character, i.e. > > anything the string "~!@#$%^&*()_+{}|:\"<>?" represents in C, it st= ops > > being recognized whatsoever. > > > >Changes from version 4: > >- Always initialize term->data from locate protocol (i.e. make it > > unconditional.) > > >=20 > Are there open issues with this patch? Is it used by Fedora? The part a= bout > SHIFT state bothers me, what happens for non-ASCII printable characters= ? > UEFI spec is extremely vague here. >=20 > As currently there is no way to actually input Ctrl-X or similar this i= s > needed. It may also allow us to actually implement keystatus on EFI. Fedora is using it, and has been for 18 months or so. As far as I know, there aren't any known issues. --=20 Peter