All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] init-ifupdown: Fix getting DNS if rootfs is network mount
Date: Mon, 12 Oct 2015 11:17:20 -0400	[thread overview]
Message-ID: <20151012151720.GA28164@edge> (raw)
In-Reply-To: <20151009114933.GF11709@denix.org>

On Fri, Oct 09, 2015 at 07:49:33AM -0400, Denys Dmytriyenko wrote:
> On Fri, Oct 09, 2015 at 07:37:35AM -0400, Jacob Stiffler wrote:
> > 
> > 
> > On 10/9/2015 7:36 AM, Denys Dmytriyenko wrote:
> > >NAK, this is wrong.
> > 
> > What is wrong about it? Is there another way to get the DNS addresses?
> 
> You assume dhcp unconditionally w/o consulting /etc/interfaces file from 
> init-ifupdown

Moreover, when rootfs is mounted over NFS, the kernel is responsible for 
assigning the IP address early on, but it can be either dynamic or static, so 
again, defaulting to dhcp here is not entirely correct.


> > >On Fri, Oct 09, 2015 at 07:33:03AM -0400, Jacob Stiffler wrote:
> > >>* Previously, if the rootfs was a network mount, then no network
> > >>   configuration was done
> > >>* This included the DHCP request to obtain the DNS addresses
> > >>* If the rootfs is a network mount, then run "udhcpc" to get the DNS
> > >>   addresses
> > >>
> > >>Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > >>---
> > >>  meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init      | 5 ++++-
> > >>  .../recipes-core/init-ifupdown/init-ifupdown_%.bbappend              | 2 +-
> > >>  2 files changed, 5 insertions(+), 2 deletions(-)
> > >>
> > >>diff --git a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init
> > >>index 86aff88..235652d 100644
> > >>--- a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init
> > >>+++ b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init
> > >>@@ -20,12 +20,15 @@ case "$1" in
> > >>          if sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\1 \2/p' /proc/mounts |
> > >>            grep -q "^/ nfs$"; then
> > >>              echo "NOT configuring network interfaces: / is an NFS mount"
> > >>+            udhcpc
> > >>          elif sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\1 \2/p' /proc/mounts |
> > >>            grep -q "^/ smbfs$"; then
> > >>              echo "NOT configuring network interfaces: / is an SMB mount"
> > >>-	elif sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\2/p' /proc/mounts |
> > >>+            udhcpc
> > >>+        elif sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\2/p' /proc/mounts |
> > >>            grep -qE '^(nfs|smbfs|ncp|coda)$'; then
> > >>              echo "NOT configuring network interfaces: network shares still mounted."
> > >>+            udhcpc
> > >>          else
> > >>              echo -n "Configuring network interfaces... "
> > >>              ifup -a
> > >>diff --git a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend
> > >>index c0ab069..997adf2 100644
> > >>--- a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend
> > >>+++ b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend
> > >>@@ -1,4 +1,4 @@
> > >>  # look for files in this layer first
> > >>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > >>-PR_append = "-arago0"
> > >>+PR_append = "-arago1"
> > >>-- 
> > >>1.9.1
> > >>
> > >>_______________________________________________
> > >>meta-arago mailing list
> > >>meta-arago@arago-project.org
> > >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > >>
> > 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


      reply	other threads:[~2015-10-12 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 11:33 [PATCH] init-ifupdown: Fix getting DNS if rootfs is network mount Jacob Stiffler
2015-10-09 11:36 ` Denys Dmytriyenko
2015-10-09 11:37   ` Jacob Stiffler
2015-10-09 11:49     ` Denys Dmytriyenko
2015-10-12 15:17       ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012151720.GA28164@edge \
    --to=denys@ti.com \
    --cc=denis@denix.org \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.