From: hch@lst.de (Christoph Hellwig)
Subject: blk-mq: fix racy updates of rq->errors
Date: Mon, 12 Oct 2015 21:15:16 +0200 [thread overview]
Message-ID: <20151012191516.GA31985@lst.de> (raw)
In-Reply-To: <20151012190522.GB31736@lst.de>
On Mon, Oct 12, 2015@09:05:22PM +0200, Christoph Hellwig wrote:
> On Tue, Oct 06, 2015@09:54:42PM +0300, Dan Carpenter wrote:
> > 622 if (req->cmd_type == REQ_TYPE_DRV_PRIV) {
> > 623 if (cmd_rq->ctx == CMD_CTX_CANCELLED)
> > 624 status = -EINTR;
> >
> > This looks like it's supposed to be a bitmap.
>
> It's not - it's a value that can have either positive (nvme status codes)
> or negative Linux errnos. It really should be an int just like req->errors
> was before. I'll send a patch to Jens.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
And next time I'll wait with the signoff until I've tested and sent
the patch :)
prev parent reply other threads:[~2015-10-12 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151006185442.GA19820@mwanda>
2015-10-12 19:05 ` blk-mq: fix racy updates of rq->errors Christoph Hellwig
2015-10-12 19:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012191516.GA31985@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.