Re: [Outreachy kernel] [PATCH v3 5/9] staging: iio: adc: add spaces around binary operators

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Oct 12, 2015 at 10:00:30PM +0300, Ioana Ciornei wrote:
> On Mon, Oct 12, 2015 at 7:38 PM, Daniel Baluta <daniel.baluta@gmail.com> wrote:
> > On Fri, Oct 9, 2015 at 10:51 PM, Ioana Ciornei <ciorneiioana@gmail.com> wrote:
> >> Add spaces around binary operators like -, +, * etc
> >> in order to improve readability
> >>
> >> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> >> ---
> >>
> >> Changes in v2:
> >>     - nothing
> >> Changes in v3:
> >>     - nothing
> >>
> >>  drivers/staging/iio/adc/ad7192.c  | 2 +-
> >>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
> >>  drivers/staging/iio/adc/ad7816.c  | 2 +-
> >>  3 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> >> index e7212c8..1bae258 100644
> >> --- a/drivers/staging/iio/adc/ad7192.c
> >> +++ b/drivers/staging/iio/adc/ad7192.c
> >> @@ -377,7 +377,7 @@ ad7192_show_scale_available(struct device *dev,
> >>  }
> >>
> >>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> >> -                            in_voltage-voltage_scale_available,
> >> +                            in_voltage - voltage_scale_available,
> >
> > This is not ok :). in_voltage-voltage_scale_available is the name of
> > an IIO sysfs
> > attribute exposed to user space. '-' is a part of the name, there is
> > no binary operator
> > here.
> >
> > If checkpatch complains about this then it's a false positive.
> 
> 
> Yes, checkpatch generated a warning and also there were no build errors.
> Sorry about this. I will send a v2.

You mean "v4", right?  This is v3 already...