From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] debugfs: Add read-only/write-only x64 file ops
Date: Tue, 13 Oct 2015 09:14:21 +0530 [thread overview]
Message-ID: <20151013034421.GP5386@linux> (raw)
In-Reply-To: <1444698552-12369-3-git-send-email-sboyd@codeaurora.org>
On 12-10-15, 18:09, Stephen Boyd wrote:
> There aren't any read-only or write-only x64 file ops, but there
> is a caller of debugfs_create_x64() that calls it with mode equal
> to S_IRUGO. This leads to the possibility of userspace modifying
> the file, so let's use the newly created debugfs_create_mode()
> helper here to fix this.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> fs/debugfs/file.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2015-10-13 3:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 1:09 [PATCH 0/4] Consolidate debugfs mode checks in creation APIs Stephen Boyd
2015-10-13 1:09 ` [PATCH 1/4] debugfs: Consolidate file mode checks in debugfs_create_*() Stephen Boyd
2015-10-13 3:43 ` Viresh Kumar
2015-10-13 1:09 ` [PATCH 2/4] debugfs: Add read-only/write-only x64 file ops Stephen Boyd
2015-10-13 3:44 ` Viresh Kumar [this message]
2015-10-13 1:09 ` [PATCH 3/4] debugfs: Add read-only/write-only size_t " Stephen Boyd
2015-10-13 3:45 ` Viresh Kumar
2015-10-13 1:09 ` [PATCH 4/4] debugfs: Add read-only/write-only bool " Stephen Boyd
2015-10-13 3:46 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013034421.GP5386@linux \
--to=viresh.kumar@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.