All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Liao Tonglang <liaotonglang@gmail.com>
Cc: arve@android.com, riandrews@android.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers :staging: android: make alignment match open parenthesis
Date: Mon, 12 Oct 2015 22:40:22 -0700	[thread overview]
Message-ID: <20151013054022.GA20952@kroah.com> (raw)
In-Reply-To: <1444707151-16990-1-git-send-email-liaotonglang@gmail.com>

On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote:
> Cleanup for checkpatch.pl warn below:
> 	CHECK: Alignment should match open parenthesis
> 	#836: FILE: drivers/staging/android/ashmem.c:836:
> by split three lines to four.
> 
> Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
> ---
>  drivers/staging/android/ashmem.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 60200a3..99fc7dc 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -832,9 +832,10 @@ static int __init ashmem_init(void)
>  {
>  	int ret;
>  
> -	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
> -					  sizeof(struct ashmem_area),
> -					  0, 0, NULL);
> +	ashmem_area_cachep =
> +		kmem_cache_create("ashmem_area_cache",
> +				  sizeof(struct ashmem_area),
> +				  0, 0, NULL);


Now you are just getting very picky for checkpatch issues, is this
really more readable?

thanks,

greg k-h

  reply	other threads:[~2015-10-13  5:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  3:32 [PATCH] drivers :staging: android: make alignment match open parenthesis Liao Tonglang
2015-10-13  5:40 ` Greg KH [this message]
2015-10-13  6:24   ` Liao Tonglang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013054022.GA20952@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=liaotonglang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.