From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Byungchul Park <byungchul.park@lge.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Subject: Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load
Date: Tue, 13 Oct 2015 09:04:36 +0200 [thread overview]
Message-ID: <20151013070436.GO3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151012174532.GB1113@lerouge>
On Mon, Oct 12, 2015 at 07:45:35PM +0200, Frederic Weisbecker wrote:
> > I think it will take more than a single patch to rework all of
> > update_process_times(). And we should also ask Thomas for his opinion,
> > but I think we want:
> >
> > - make update_process_times() take a nr_ticks argument
> > - fixup everything below it
> >
> > - fix tick_nohz_handler to not ignore the hrtimer_forward()
> > return value and pass it into
> > tick_sched_handle()/update_process_times().
> >
> > (assuming this is the right oneshot tick part, tick-common
> > seems to be about periodic timers which aren't used much ?!)
>
> this_nohz_handler() is the low res nohz handler. tick_sched_handle()
> is the high res one (I should rename these). I think we should rather
> find out the pending updates from update_process_times() itself and pass
> it to scheduler_tick() which is the one interested in it.
tick_nohz_handler() calls tick_sched_handler() ?!
And tick_nohz_handler() actually computes the number of ticks -- which
we then happily ignore.
Why compute it again a few functions down?
next prev parent reply other threads:[~2015-10-13 7:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 7:46 [PATCH v3 0/2] sched: consider missed ticks when updating cpu load byungchul.park
2015-10-02 7:46 ` [PATCH v3 1/2] sched: make __update_cpu_load() handle active tickless case byungchul.park
2015-10-02 7:46 ` [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load byungchul.park
2015-10-02 15:59 ` Peter Zijlstra
2015-10-04 6:58 ` Byungchul Park
2015-10-05 8:15 ` Peter Zijlstra
2015-10-12 17:45 ` Frederic Weisbecker
2015-10-13 7:04 ` Peter Zijlstra [this message]
2015-10-13 8:37 ` Byungchul Park
2015-10-13 14:55 ` Frederic Weisbecker
2015-10-13 14:51 ` Frederic Weisbecker
2015-10-13 14:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013070436.GO3604@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=byungchul.park@lge.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.