From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbbJMISL (ORCPT ); Tue, 13 Oct 2015 04:18:11 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38361 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbbJMISI (ORCPT ); Tue, 13 Oct 2015 04:18:08 -0400 Date: Tue, 13 Oct 2015 09:18:04 +0100 From: Lee Jones To: Axel Lin Cc: Support Opensource , Steve Twiss , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: da9062-core: Rename get_device_type to da9062_get_device_type Message-ID: <20151013081804.GC17172@x1> References: <1444386123.24317.1.camel@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1444386123.24317.1.camel@ingics.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Oct 2015, Axel Lin wrote: > Rename get_device_type() to da9062_get_device_type(). > This function is only used in this file so make it static. > > Signed-off-by: Axel Lin > --- > drivers/mfd/da9062-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c > index f80d947..a9ad024 100644 > --- a/drivers/mfd/da9062-core.c > +++ b/drivers/mfd/da9062-core.c > @@ -198,7 +198,7 @@ static int da9062_clear_fault_log(struct da9062 *chip) > return ret; > } > > -int get_device_type(struct da9062 *chip) > +static int da9062_get_device_type(struct da9062 *chip) > { > int device_id, variant_id, variant_mrc; > int ret; > @@ -466,7 +466,7 @@ static int da9062_i2c_probe(struct i2c_client *i2c, > if (ret < 0) > dev_warn(chip->dev, "Cannot clear fault log\n"); > > - ret = get_device_type(chip); > + ret = da9062_get_device_type(chip); > if (ret) > return ret; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog