From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Hold dev->event_lock whilst
 inspecting intel_crtc->unpin_work
Date: Tue, 13 Oct 2015 12:23:38 +0300
Message-ID: <20151013092338.GM26517@intel.com>
References: <1444470272-11952-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id ED3966E8EE
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 Oct 2015 02:23:42 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1444470272-11952-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gU2F0LCBPY3QgMTAsIDIwMTUgYXQgMTA6NDQ6MzJBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFdlIHNob3VsZCBzZXJpYWxpc2UgYWNjZXNzIHRvIHRoZSBpbnRlbF9jcnRjLT51bnBp
bl93b3JrIHRocm91Z2ggdGhlCj4gZGV2LT5ldmVudF9sb2NrIHNwaW5sb2NrLiBJdCBzaG91bGQg
bm90IGJlIHBvc3NpYmxlIGZvciBpdCB0byBkaXNhcHBlYXIKPiB3aXRob3V0IHNldmVyZSBlcnJv
ciBhcyB0aGUgbW1pb19mbGlwIHdvcmtlciBoYXMgbm90IHRhZ2dlZCB0aGUKPiB1bnBpbl93b3Jr
IHBlbmRpbmcgZmxpcC1jb21wbGV0aW9uLiBTaW1pbGFybHkgaWYgdGhlIGVycm9yIGV4aXN0cywg
anVzdAo+IHRha2luZyB0aGUgdW5waW5fd29yayB3aGlsc3QgaG9sZGluZyB0aGUgc3BpbmxvY2sg
YW5kIHRoZW4gdXNpbmcgaXQKPiB1bnNlcmlhbGlzZWQganVzdCBtYXNrcyB0aGUgcmFjZS4gKEl0
IGlzIHN1cHBvc2VkIHRvIGJlIHZhbGlkIGFzIHRoZQo+IHVucGluX3dvcmsgZXhpc3RzIHVudGls
IHRoZSBmbGlwIGNvbXBsZXRpb24gaW50ZXJydXB0IHdoaWNoIHNob3VsZCBub3QKPiBmaXJlIHVu
dGlsIHdlIGZsdXNoIHRoZSBtbWlvIHdyaXRlcyB0byB1cGRhdGUgdGhlIGRpc3BsYXkgYmFzZSB3
aGljaCBpcwo+IHRoZSBsYXN0IHRpbWUgd2UgYWNjZXNzIHRoZSB1bnBpbl93b3JrIGZyb20gdGhl
IGt0aHJlYWQuKQo+IAo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcv
c2hvd19idWcuY2dpP2lkPTkyMzM1Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp
c0BjaHJpcy13aWxzb24uY28udWs+CgpTbyBub3Qgc3VyZSB3aGF0J3MgZ29pbmcgb24geWV0PwoK
UGF0Y2ggbG9va3MgT0sgYW55d2F5IHNvClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp
bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGlzcGxheS5jIHwgNTcgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t
LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkK
PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggY2RkYjBjNjkyMzM0
Li43MWQ3Mjk4NjQ4ZTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g
QEAgLTEwODQ4LDExICsxMDg0OCwxMSBAQCB2b2lkIGludGVsX3ByZXBhcmVfcGFnZV9mbGlwKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBwbGFuZSkKPiAgCXNwaW5fdW5sb2NrX2lycXJlc3Rv
cmUoJmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW5saW5lIHZv
aWQgaW50ZWxfbWFya19wYWdlX2ZsaXBfYWN0aXZlKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9j
cnRjKQo+ICtzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfbWFya19wYWdlX2ZsaXBfYWN0aXZlKHN0
cnVjdCBpbnRlbF91bnBpbl93b3JrICp3b3JrKQo+ICB7Cj4gIAkvKiBFbnN1cmUgdGhhdCB0aGUg
d29yayBpdGVtIGlzIGNvbnNpc3RlbnQgd2hlbiBhY3RpdmF0aW5nIGl0IC4uLiAqLwo+ICAJc21w
X3dtYigpOwo+IC0JYXRvbWljX3NldCgmaW50ZWxfY3J0Yy0+dW5waW5fd29yay0+cGVuZGluZywg
SU5URUxfRkxJUF9QRU5ESU5HKTsKPiArCWF0b21pY19zZXQoJndvcmstPnBlbmRpbmcsIElOVEVM
X0ZMSVBfUEVORElORyk7Cj4gIAkvKiBhbmQgdGhhdCBpdCBpcyBtYXJrZWQgYWN0aXZlIGFzIHNv
b24gYXMgdGhlIGlycSBjb3VsZCBmaXJlLiAqLwo+ICAJc21wX3dtYigpOwo+ICB9Cj4gQEAgLTEw
ODg4LDcgKzEwODg4LDcgQEAgc3RhdGljIGludCBpbnRlbF9nZW4yX3F1ZXVlX2ZsaXAoc3RydWN0
IGRybV9kZXZpY2UgKmRldiwKPiAgCWludGVsX3JpbmdfZW1pdChyaW5nLCBpbnRlbF9jcnRjLT51
bnBpbl93b3JrLT5ndHRfb2Zmc2V0KTsKPiAgCWludGVsX3JpbmdfZW1pdChyaW5nLCAwKTsgLyog
YXV4IGRpc3BsYXkgYmFzZSBhZGRyZXNzLCB1bnVzZWQgKi8KPiAgCj4gLQlpbnRlbF9tYXJrX3Bh
Z2VfZmxpcF9hY3RpdmUoaW50ZWxfY3J0Yyk7Cj4gKwlpbnRlbF9tYXJrX3BhZ2VfZmxpcF9hY3Rp
dmUoaW50ZWxfY3J0Yy0+dW5waW5fd29yayk7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiBAQCAt
MTA5MjAsNyArMTA5MjAsNyBAQCBzdGF0aWMgaW50IGludGVsX2dlbjNfcXVldWVfZmxpcChzdHJ1
Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJaW50ZWxfcmluZ19lbWl0KHJpbmcsIGludGVsX2NydGMt
PnVucGluX3dvcmstPmd0dF9vZmZzZXQpOwo+ICAJaW50ZWxfcmluZ19lbWl0KHJpbmcsIE1JX05P
T1ApOwo+ICAKPiAtCWludGVsX21hcmtfcGFnZV9mbGlwX2FjdGl2ZShpbnRlbF9jcnRjKTsKPiAr
CWludGVsX21hcmtfcGFnZV9mbGlwX2FjdGl2ZShpbnRlbF9jcnRjLT51bnBpbl93b3JrKTsKPiAg
CXJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC0xMDk1OSw3ICsxMDk1OSw3IEBAIHN0YXRpYyBpbnQg
aW50ZWxfZ2VuNF9xdWV1ZV9mbGlwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlwaXBlc3Jj
ID0gSTkxNV9SRUFEKFBJUEVTUkMoaW50ZWxfY3J0Yy0+cGlwZSkpICYgMHgwZmZmMGZmZjsKPiAg
CWludGVsX3JpbmdfZW1pdChyaW5nLCBwZiB8IHBpcGVzcmMpOwo+ICAKPiAtCWludGVsX21hcmtf
cGFnZV9mbGlwX2FjdGl2ZShpbnRlbF9jcnRjKTsKPiArCWludGVsX21hcmtfcGFnZV9mbGlwX2Fj
dGl2ZShpbnRlbF9jcnRjLT51bnBpbl93b3JrKTsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IEBA
IC0xMDk5NSw3ICsxMDk5NSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfZ2VuNl9xdWV1ZV9mbGlwKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlwaXBlc3JjID0gSTkxNV9SRUFEKFBJUEVTUkMoaW50
ZWxfY3J0Yy0+cGlwZSkpICYgMHgwZmZmMGZmZjsKPiAgCWludGVsX3JpbmdfZW1pdChyaW5nLCBw
ZiB8IHBpcGVzcmMpOwo+ICAKPiAtCWludGVsX21hcmtfcGFnZV9mbGlwX2FjdGl2ZShpbnRlbF9j
cnRjKTsKPiArCWludGVsX21hcmtfcGFnZV9mbGlwX2FjdGl2ZShpbnRlbF9jcnRjLT51bnBpbl93
b3JrKTsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC0xMTA5MCw3ICsxMTA5MCw3IEBAIHN0
YXRpYyBpbnQgaW50ZWxfZ2VuN19xdWV1ZV9mbGlwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g
IAlpbnRlbF9yaW5nX2VtaXQocmluZywgaW50ZWxfY3J0Yy0+dW5waW5fd29yay0+Z3R0X29mZnNl
dCk7Cj4gIAlpbnRlbF9yaW5nX2VtaXQocmluZywgKE1JX05PT1ApKTsKPiAgCj4gLQlpbnRlbF9t
YXJrX3BhZ2VfZmxpcF9hY3RpdmUoaW50ZWxfY3J0Yyk7Cj4gKwlpbnRlbF9tYXJrX3BhZ2VfZmxp
cF9hY3RpdmUoaW50ZWxfY3J0Yy0+dW5waW5fd29yayk7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAK
PiBAQCAtMTExMjEsNyArMTExMjEsOCBAQCBzdGF0aWMgYm9vbCB1c2VfbW1pb19mbGlwKHN0cnVj
dCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4gIAkJcmV0dXJuIHJpbmcgIT0gaTkxNV9nZW1fcmVx
dWVzdF9nZXRfcmluZyhvYmotPmxhc3Rfd3JpdGVfcmVxKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZv
aWQgc2tsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiArc3Rh
dGljIHZvaWQgc2tsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywK
PiArCQkJICAgICBzdHJ1Y3QgaW50ZWxfdW5waW5fd29yayAqd29yaykKPiAgewo+ICAJc3RydWN0
IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2NydGMtPmJhc2UuZGV2Owo+ICAJc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiBAQCAtMTExNjIsMTEg
KzExMTYzLDEyIEBAIHN0YXRpYyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2Ny
dGMgKmludGVsX2NydGMpCj4gIAlJOTE1X1dSSVRFKFBMQU5FX0NUTChwaXBlLCAwKSwgY3RsKTsK
PiAgCUk5MTVfV1JJVEUoUExBTkVfU1RSSURFKHBpcGUsIDApLCBzdHJpZGUpOwo+ICAKPiAtCUk5
MTVfV1JJVEUoUExBTkVfU1VSRihwaXBlLCAwKSwgaW50ZWxfY3J0Yy0+dW5waW5fd29yay0+Z3R0
X29mZnNldCk7Cj4gKwlJOTE1X1dSSVRFKFBMQU5FX1NVUkYocGlwZSwgMCksIHdvcmstPmd0dF9v
ZmZzZXQpOwo+ICAJUE9TVElOR19SRUFEKFBMQU5FX1NVUkYocGlwZSwgMCkpOwo+ICB9Cj4gIAo+
IC1zdGF0aWMgdm9pZCBpbGtfZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9j
cnRjKQo+ICtzdGF0aWMgdm9pZCBpbGtfZG9fbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9jcnRjICpp
bnRlbF9jcnRjLAo+ICsJCQkgICAgIHN0cnVjdCBpbnRlbF91bnBpbl93b3JrICp3b3JrKQo+ICB7
Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfY3J0Yy0+YmFzZS5kZXY7Cj4gIAlz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IEBA
IC0xMTE4NiwzMSArMTExODgsMzYgQEAgc3RhdGljIHZvaWQgaWxrX2RvX21taW9fZmxpcChzdHJ1
Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPiAgCj4gIAlJOTE1X1dSSVRFKHJlZywgZHNwY250
cik7Cj4gIAo+IC0JSTkxNV9XUklURShEU1BTVVJGKGludGVsX2NydGMtPnBsYW5lKSwKPiAtCQkg
ICBpbnRlbF9jcnRjLT51bnBpbl93b3JrLT5ndHRfb2Zmc2V0KTsKPiArCUk5MTVfV1JJVEUoRFNQ
U1VSRihpbnRlbF9jcnRjLT5wbGFuZSksIHdvcmstPmd0dF9vZmZzZXQpOwo+ICAJUE9TVElOR19S
RUFEKERTUFNVUkYoaW50ZWxfY3J0Yy0+cGxhbmUpKTsKPiAtCj4gIH0KPiAgCj4gIC8qCj4gICAq
IFhYWDogVGhpcyBpcyB0aGUgdGVtcG9yYXJ5IHdheSB0byB1cGRhdGUgdGhlIHBsYW5lIHJlZ2lz
dGVycyB1bnRpbCB3ZSBnZXQKPiAgICogYXJvdW5kIHRvIHVzaW5nIHRoZSB1c3VhbCBwbGFuZSB1
cGRhdGUgZnVuY3Rpb25zIGZvciBNTUlPIGZsaXBzCj4gICAqLwo+IC1zdGF0aWMgdm9pZCBpbnRl
bF9kb19tbWlvX2ZsaXAoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gK3N0YXRpYyB2
b2lkIGludGVsX2RvX21taW9fZmxpcChzdHJ1Y3QgaW50ZWxfbW1pb19mbGlwICptbWlvX2ZsaXAp
Cj4gIHsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5iYXNlLmRldjsK
PiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gbW1pb19mbGlwLT5jcnRjOwo+ICsJc3RydWN0
IGludGVsX3VucGluX3dvcmsgKndvcms7Cj4gIAo+IC0JaW50ZWxfbWFya19wYWdlX2ZsaXBfYWN0
aXZlKGludGVsX2NydGMpOwo+ICsJc3Bpbl9sb2NrX2lycSgmY3J0Yy0+YmFzZS5kZXYtPmV2ZW50
X2xvY2spOwo+ICsJd29yayA9IGNydGMtPnVucGluX3dvcms7Cj4gKwlzcGluX3VubG9ja19pcnEo
JmNydGMtPmJhc2UuZGV2LT5ldmVudF9sb2NrKTsKPiArCWlmICh3b3JrID09IE5VTEwpCj4gKwkJ
cmV0dXJuOwo+Cj4gLQlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChpbnRlbF9jcnRjKTsKPiArCWlu
dGVsX21hcmtfcGFnZV9mbGlwX2FjdGl2ZSh3b3JrKTsKPiAgCj4gLQlpZiAoSU5URUxfSU5GTyhk
ZXYpLT5nZW4gPj0gOSkKPiAtCQlza2xfZG9fbW1pb19mbGlwKGludGVsX2NydGMpOwo+ICsJaW50
ZWxfcGlwZV91cGRhdGVfc3RhcnQoY3J0Yyk7Cj4gKwo+ICsJaWYgKElOVEVMX0lORk8obW1pb19m
bGlwLT5pOTE1KS0+Z2VuID49IDkpCj4gKwkJc2tsX2RvX21taW9fZmxpcChjcnRjLCB3b3JrKTsK
PiAgCWVsc2UKPiAgCQkvKiB1c2VfbW1pb19mbGlwKCkgcmV0cmljdHMgTU1JTyBmbGlwcyB0byBp
bGsrICovCj4gLQkJaWxrX2RvX21taW9fZmxpcChpbnRlbF9jcnRjKTsKPiArCQlpbGtfZG9fbW1p
b19mbGlwKGNydGMsIHdvcmspOwo+ICAKPiAtCWludGVsX3BpcGVfdXBkYXRlX2VuZChpbnRlbF9j
cnRjKTsKPiArCWludGVsX3BpcGVfdXBkYXRlX2VuZChjcnRjKTsKPiAgfQo+ICAKPiAgc3RhdGlj
IHZvaWQgaW50ZWxfbW1pb19mbGlwX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmsp
Cj4gQEAgLTExMjE4LDE1ICsxMTIyNSwxNSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tbWlvX2ZsaXBf
d29ya19mdW5jKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCXN0cnVjdCBpbnRlbF9tbWlv
X2ZsaXAgKm1taW9fZmxpcCA9Cj4gIAkJY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBpbnRlbF9t
bWlvX2ZsaXAsIHdvcmspOwo+ICAKPiAtCWlmIChtbWlvX2ZsaXAtPnJlcSkKPiArCWlmIChtbWlv
X2ZsaXAtPnJlcSkgewo+ICAJCVdBUk5fT04oX19pOTE1X3dhaXRfcmVxdWVzdChtbWlvX2ZsaXAt
PnJlcSwKPiAgCQkJCQkgICAgbW1pb19mbGlwLT5jcnRjLT5yZXNldF9jb3VudGVyLAo+ICAJCQkJ
CSAgICBmYWxzZSwgTlVMTCwKPiAgCQkJCQkgICAgJm1taW9fZmxpcC0+aTkxNS0+cnBzLm1taW9m
bGlwcykpOwo+ICsJCWk5MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVuY2VfX3VubG9ja2VkKG1taW9f
ZmxpcC0+cmVxKTsKPiArCX0KPiAgCj4gLQlpbnRlbF9kb19tbWlvX2ZsaXAobW1pb19mbGlwLT5j
cnRjKTsKPiAtCj4gLQlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlX191bmxvY2tlZChtbWlv
X2ZsaXAtPnJlcSk7Cj4gKwlpbnRlbF9kb19tbWlvX2ZsaXAobW1pb19mbGlwKTsKPiAgCWtmcmVl
KG1taW9fZmxpcCk7Cj4gIH0KPiAgCj4gLS0gCj4gMi42LjEKPiAKPiBfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QK
PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJ
bnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK