From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbbJMJqg (ORCPT ); Tue, 13 Oct 2015 05:46:36 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:59185 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbbJMJqe (ORCPT ); Tue, 13 Oct 2015 05:46:34 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWi/zfN1cLnDYUEsRQLYl4HhAfxvoMVLJDy7TDPdkLO/Iwdu4oA= X-RZG-CLASS-ID: mo00 Date: Tue, 13 Oct 2015 11:46:30 +0200 From: Olaf Hering To: KY Srinivasan Cc: Vitaly Kuznetsov , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "apw@canonical.com" , "jasowang@redhat.com" Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context Message-ID: <20151013094630.GA28456@aepfle.de> References: <1444269571-25217-1-git-send-email-kys@microsoft.com> <1444269709-25270-1-git-send-email-kys@microsoft.com> <1444269709-25270-2-git-send-email-kys@microsoft.com> <87r3l5ebmj.fsf@vitty.brq.redhat.com> <20151008133037.GA31748@aepfle.de> <87mvvteabq.fsf@vitty.brq.redhat.com> <20151009070757.GA27773@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151009070757.GA27773@aepfle.de> User-Agent: Mutt/1.5.24 (6517) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, Olaf Hering wrote: > On Thu, Oct 08, KY Srinivasan wrote: > > > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > > > check in place, better safe than sorry. > > > > Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with this part reverted. I think without two code paths > entering hv_fcopy_callback it should be ok to leave this check in. Today I restored the "fcopy_transaction.state != HVUTIL_USERSPACE_REQ" check and its working fine. Olaf