From: Rabin Vincent <rabin.vincent@axis.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind
Date: Tue, 13 Oct 2015 12:51:17 +0200 [thread overview]
Message-ID: <20151013105116.GB3628@axis.com> (raw)
In-Reply-To: <CAM9d7cgnoZWsDnWbFbxDYj7rMkAS_FSsY6gjEPv0zeW4nVyuuA@mail.gmail.com>
On Mon, Oct 12, 2015 at 02:35:08PM +0200, Namhyung Kim wrote:
> On Mon, Oct 12, 2015 at 8:24 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote:
> >> Even if --symfs is used to point to the debug binaries, we send in the
> >> non-debug filenames to libunwind, which leads to libunwind not finding
> >> the debug frame. Fix this.
> >>
> >> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
> >
> > cc-ing Namhyung on this one
>
> It seems that the dso->symsrc_filename can be NULL and it's unsafe to
> call dwarf_find_debug_frame() with the NULL pointer. Other than that
> looks good to me.
Thanks, I will change it to fallback to dso->name if
dso->symsrc_filename is NULL.
next prev parent reply other threads:[~2015-10-13 10:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 18:37 [PATCH 1/5] perf: unwind: fix unw_word_t pointer casts Rabin Vincent
2015-09-27 18:37 ` [PATCH 2/5] perf: unwind: pass symbol source to libunwind Rabin Vincent
2015-10-12 11:24 ` Jiri Olsa
2015-10-12 12:35 ` Namhyung Kim
2015-10-13 10:51 ` Rabin Vincent [this message]
2015-09-27 18:37 ` [PATCH 3/5] perf: unwind: use debug_frame if eh_frame is unusable Rabin Vincent
2015-10-12 11:28 ` Jiri Olsa
2015-10-14 13:13 ` [tip:perf/core] perf callchain: Use " tip-bot for Rabin Vincent
2015-09-27 18:37 ` [PATCH 4/5] tools: build: fix libiberty feature detection Rabin Vincent
2015-10-12 11:35 ` Jiri Olsa
2015-10-13 11:00 ` Rabin Vincent
2015-09-27 18:37 ` [PATCH 5/5] perf: add Makefile.deps for easier cross compiling Rabin Vincent
2015-10-12 11:42 ` Jiri Olsa
2015-10-13 10:50 ` Rabin Vincent
2015-10-13 11:52 ` Jiri Olsa
2015-10-10 15:49 ` [PATCH 1/5] perf: unwind: fix unw_word_t pointer casts Rabin Vincent
2015-10-10 23:34 ` Arnaldo Carvalho de Melo
2015-10-12 8:38 ` Jiri Olsa
2015-10-14 13:14 ` [tip:perf/core] perf callchains: Fix " tip-bot for Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013105116.GB3628@axis.com \
--to=rabin.vincent@axis.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.