Re: [PATCH v4 2/2] input: rotary encoder: Add wake up support

[Johan Hovold <johan@kernel.org>]

On Mon, Oct 12, 2015 at 09:13:32PM +0200, Sylvain Rochet wrote:
> This patch adds wake up support to GPIO rotary encoders.
> 
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> Reviewed-by: Johan Hovold <johan@kernel.org>

Hmm. I have not yet reviewed the changes you did in v4.

> ---
>  drivers/input/misc/rotary_encoder.c | 39 +++++++++++++++++++++++++++++++++++++
>  include/linux/rotary_encoder.h      |  1 +
>  2 files changed, 40 insertions(+)
> 
> diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
> index f27f81e..0d86dc4 100644
> --- a/drivers/input/misc/rotary_encoder.c
> +++ b/drivers/input/misc/rotary_encoder.c

> @@ -280,6 +283,10 @@ static int rotary_encoder_probe(struct platform_device *pdev)
>  		goto exit_free_irq_b;
>  	}
>  
> +	device_set_wakeup_capable(&pdev->dev, true);

You should continue to use the platform data to determine whether the
device is capable of wakeup or not.

> +	if (pdata->wakeup_source)
> +		device_wakeup_enable(&pdev->dev);
> +

Just stick to

	device_init_wakeup(&pdev->dev, pdata->wakeup_source);

as in v3.

Johan