From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932423AbbJMOZp (ORCPT ); Tue, 13 Oct 2015 10:25:45 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:32875 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbbJMOZn (ORCPT ); Tue, 13 Oct 2015 10:25:43 -0400 Date: Tue, 13 Oct 2015 16:19:46 +0200 From: Ingo Molnar To: Dmitry Vyukov Cc: Andrey Ryabinin , LKML , Thomas Gleixner , "H. Peter Anvin" , "x86@kernel.org" , Andrew Morton , Andy Lutomirski , Andrey Konovalov , Kostya Serebryany , Alexander Potapenko , kasan-dev , Borislav Petkov , Denys Vlasenko , Andi Kleen , Sasha Levin , Wolfram Gloger Subject: Re: [PATCH v2 2/2] x86/process: Silence KASAN warnings in get_wchan() Message-ID: <20151013141946.GA10135@gmail.com> References: <1444739750-29241-1-git-send-email-aryabinin@virtuozzo.com> <1444739750-29241-3-git-send-email-aryabinin@virtuozzo.com> <20151013134859.GB8843@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dmitry Vyukov wrote: > > Hm, exactly how is the 'red zone' defined? Is this about the current task > > mostly, or when doing get_wchan() on other tasks? > > When code is compiled with AddressSanitizer, most variables on stack have > redzones around them, on entry function "poisons" these redzones (any accesses > to them will be flagged), on exit function "unpoisons" these redzones. I see, fair enough! This series looks good to me, modulo the small documentation nit I had about the first patch. Thanks, Ingo