All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/2] Fix various issues
Date: Tue, 13 Oct 2015 07:24:46 -0700	[thread overview]
Message-ID: <20151013142446.GA7818@kroah.com> (raw)
In-Reply-To: <cover.1444733999.git.shivanib134@gmail.com>

On Tue, Oct 13, 2015 at 04:33:56PM +0530, Shivani Bhardwaj wrote:
> This patch removes unused code and changes the variable type to more
> effective one.
> After applying this patch, code becomes better.

Ok, not to pick on just this patch, but everyone's 0/X emails need a bit
more work please.

First off, they need 'staging' in them, and then need to be a bit more
descriptive as to what the patch series does (hint, this one is really
vague.)

Don't worry about this one, I'll take it, but in the future, if
_everyone_ could work on their 0/X emails, I would greatly appreciate
it.

thanks,

greg k-h


  parent reply	other threads:[~2015-10-13 14:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 11:03 [PATCH 0/2] Fix various issues Shivani Bhardwaj
2015-10-13 11:04 ` [PATCH 1/2] Staging: wilc1000: wilc_wfi_cfgoperations: Remove unused code Shivani Bhardwaj
2015-10-13 11:04 ` [PATCH 2/2] Staging: wilc1000: wilc_wfi_cfgoperations: Change variable to bool Shivani Bhardwaj
2015-10-13 11:20   ` [Outreachy kernel] " Julia Lawall
2015-10-13 12:46     ` Shivani Bhardwaj
2015-10-13 12:48       ` Julia Lawall
2015-10-13 12:51         ` Shivani Bhardwaj
2015-10-13 14:24 ` Greg KH [this message]
2015-10-13 14:26   ` [Outreachy kernel] [PATCH 0/2] Fix various issues Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013142446.GA7818@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.