From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ivan Safonov <insafonov@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8188eu: 5 GHz channel groups removed from /hal/rtl8188e_hal_init.c
Date: Tue, 13 Oct 2015 08:40:31 -0700 [thread overview]
Message-ID: <20151013154031.GA6592@kroah.com> (raw)
In-Reply-To: <561D1C99.1070008@gmail.com>
On Tue, Oct 13, 2015 at 10:00:41PM +0700, Ivan Safonov wrote:
> On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote:
> >On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote:
> >>Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E
> >>and it transformed to pretty get_channel_group(const u8 channel).
> >>
> >>Also removed code for 5 GHz frequency in Hal_ReadPowerValueFromPROM_8188E.
> >Why did you do two different things in this patch?
> >
> >Have you tested this?
> >
> >thanks,
> >
> >greg k-h
>
> Split this patch into two parts?
Why wouldn't you?
> I have not tested it.
Please test it.
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-13 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 6:23 [PATCH 1/3] staging: rtl8188eu: 5 GHz channel groups removed from /hal/rtl8188e_hal_init.c Ivan Safonov
2015-10-13 3:47 ` Greg Kroah-Hartman
2015-10-13 15:00 ` Ivan Safonov
2015-10-13 15:40 ` Greg Kroah-Hartman [this message]
2015-10-13 15:48 ` Ivan Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013154031.GA6592@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.