All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3 1/3] Staging: wilc1000: host_interface: Remove extra NULL test
Date: Tue, 13 Oct 2015 10:06:40 -0700	[thread overview]
Message-ID: <20151013170640.GA420@kroah.com> (raw)
In-Reply-To: <a9433e724043b5e3a1da566a95a13e94e7205851.1444719312.git.shivanib134@gmail.com>

On Tue, Oct 13, 2015 at 12:36:44PM +0530, Shivani Bhardwaj wrote:
> Remove NULL test on a variable as it is preceded by another NULL
> test on the same variable in the code. Also, it is unnecessary to
> NULL test before kfree().
> Semantic patch used:
> 
> @@ expression E; @@
> - if(E!=NULL){
> - 	kfree(E);
> - }
> + kfree(E);
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
> Changes in v3:
> 	-Fix errors in v2 and improve commit message by adding
> 	semantic patches used by coccinelle.

This series doesn't apply to my tree due to other patches in this area
from other developers :(


  parent reply	other threads:[~2015-10-13 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  7:06 [PATCH v3 0/3] Fix issues discovered by coccinelle Shivani Bhardwaj
2015-10-13  7:06 ` [PATCH v3 1/3] Staging: wilc1000: host_interface: Remove extra NULL test Shivani Bhardwaj
2015-10-13  7:45   ` [Outreachy kernel] " Daniel Baluta
2015-10-13 17:06   ` Greg KH [this message]
2015-10-13  7:07 ` [PATCH v3 2/3] Staging: wilc1000: host_interface: Remove unnecessary typedef and code Shivani Bhardwaj
2015-10-13  7:08 ` [PATCH v3 3/3] Staging: wilc1000: host_interface: Remove unnecessary cast Shivani Bhardwaj
2015-10-13  7:49   ` [Outreachy kernel] " Julia Lawall
2015-10-13  7:51     ` Shivani Bhardwaj
2015-10-13 10:48       ` Shivani Bhardwaj
2015-10-13 11:18         ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013170640.GA420@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.