From: Andrei Gherzan <andrei@gherzan.ro>
To: Jonathan Liu <net147@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
Date: Tue, 13 Oct 2015 19:46:24 +0200 [thread overview]
Message-ID: <20151013174624.GA8800@resin> (raw)
In-Reply-To: <1443924933-29412-1-git-send-email-net147@gmail.com>
On Sun, Oct 04, 2015 at 01:15:33PM +1100, Jonathan Liu wrote:
> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index d60a3e9..70e8bfe 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -12,7 +12,8 @@ SRC_URI += " \
>
> COMPATIBLE_MACHINE = "raspberrypi"
>
> -PV = "${LINUX_VERSION}+git${SRCREV}"
> +PE = "1"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
>
> # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
> KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
> --
> 2.6.0
>
I tested build locally and based on your comments on PE I merged this patch.
Thanks,
--
Andrei Gherzan
prev parent reply other threads:[~2015-10-13 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 2:15 [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV Jonathan Liu
2015-10-04 10:50 ` Andreas Müller
2015-10-04 11:14 ` Jonathan Liu
2015-10-13 17:46 ` Andrei Gherzan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013174624.GA8800@resin \
--to=andrei@gherzan.ro \
--cc=net147@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.