All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beniamino Galvani <b.galvani@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI
Date: Tue, 13 Oct 2015 20:28:14 +0200	[thread overview]
Message-ID: <20151013182814.GA4175@gmail.com> (raw)
In-Reply-To: <eda3f569d6f605bc985a88fc3d9be7fca380a780.1444448892.git.crosthwaite.peter@gmail.com>

On Sun, Oct 11, 2015 at 09:21:35AM -0700, Peter Crosthwaite wrote:
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1692,9 +1692,107 @@ static const TypeInfo sysbus_ahci_info = {
>      .class_init    = sysbus_ahci_class_init,
>  };
>  
> +#define ALLWINNER_AHCI_MMIO_OFF  0x80
> +#define ALLWINNER_AHCI_MMIO_SIZE 0x80

These are already defined in the header file.

> +static const VMStateDescription vmstate_allwinner_ahci = {
> +    .name = "a10.pic",

.name = "allwinner-ahci" ?

Beniamino

  parent reply	other threads:[~2015-10-13 18:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 16:21 [Qemu-devel] [RFC 0/4] AHCI patches + Allwinner SATA Peter Crosthwaite
2015-10-11 16:21 ` [Qemu-devel] [RFC 1/4] ahci: Add some MMIO debug printfs Peter Crosthwaite
2015-10-11 16:21 ` [Qemu-devel] [RFC 2/4] ahci: split realize and init Peter Crosthwaite
2015-10-11 16:21 ` [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI Peter Crosthwaite
2015-10-12 23:09   ` John Snow
2015-10-13  4:58     ` Peter Crosthwaite
2015-10-13 18:28   ` Beniamino Galvani [this message]
2015-10-26 15:48     ` Peter Crosthwaite
2015-10-11 16:21 ` [Qemu-devel] [RFC 4/4] arm: allwinner-a10: Add SATA Peter Crosthwaite
2015-10-12 22:32   ` John Snow
2015-10-13  4:55     ` Peter Crosthwaite
2015-10-12 20:41 ` [Qemu-devel] [RFC 0/4] AHCI patches + Allwinner SATA Beniamino Galvani
2015-10-13  5:02   ` Peter Crosthwaite
2015-10-26 15:25 ` John Snow
2015-10-29 16:41   ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013182814.GA4175@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.