From: Lee Jones <lee.jones@linaro.org>
To: "Yang, Fei" <fei.yang@intel.com>
Cc: Borun Fu <borun.fu@linux.intel.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
"jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs
Date: Wed, 14 Oct 2015 08:08:16 +0100 [thread overview]
Message-ID: <20151014070816.GD32409@x1> (raw)
In-Reply-To: <02E7334B1630744CBDC55DA8586225834A6F8C6B@ORSMSX102.amr.corp.intel.com>
On Tue, 13 Oct 2015, Yang, Fei wrote:
> >> static struct resource axp288_fuel_gauge_resources[] = {
> >> {
> >> .start = AXP288_IRQ_QWBTU,
> >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >> .resources = axp288_fuel_gauge_resources,
> >> },
> >> {
> >> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >
> >Doesn't this change insinuate that?
> >
> >If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right?
>
> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
I am.
> >> + .num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >> + .resources = axp288_power_button_resources,
> >> + },
> >> + {
> >> .name = "axp288_pmic_acpi",
> >> },
> >> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-10-14 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 7:16 [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Borun Fu
2015-10-13 8:11 ` Lee Jones
2015-10-13 18:33 ` Yang, Fei
2015-10-14 7:08 ` Lee Jones [this message]
2015-10-14 7:47 ` Borun Fu
2015-10-14 8:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014070816.GD32409@x1 \
--to=lee.jones@linaro.org \
--cc=borun.fu@linux.intel.com \
--cc=fei.yang@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.