Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Oct 14, 2015 at 10:53:14AM +0300, Pavel Fedin wrote:
> On ARM architecture ITS (Interrupt Translation Service), additionally to
> normal MSI data, uses also side-band device IDs. This series prepares the
> infrastructure to handling them.
> 
> This small series is actually an extraction from vITS support RFC
> (https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg07074.html).
> Nobody reviewed it so far, however some bits of it could actually be
> applied early. This series consists only of those parts, which do not
> depend on any new unreleased kernel APIs.

I'm confused by pci changes.  It's all arm specific stuff leaking
out to pci core.

Maybe it was a mistake to put stream id in struct MemTxAttrs: there's
still nothing using it.

How about we stick PCIDevice * (or even DeviceState *) there?
Would that be enough to get rid of stream_id completely?

> v1 => v2:
> - Improved commit messages, more explanations
> - msi_device_id() function made architecture-specific
> 
> Pavel Fedin (3):
>   kvm: Make KVM_CAP_SIGNAL_MSI globally available
>   hw/pci: Introduce msi_device_id()
>   kvm: Pass PCI device pointer to MSI routing functions
> 
>  hw/i386/kvm/pci-assign.c |  9 +++++----
>  hw/pci/msi.c             |  2 +-
>  hw/vfio/pci.c            | 11 ++++++-----
>  hw/virtio/virtio-pci.c   |  5 +++--
>  include/hw/pci/msi.h     |  1 +
>  include/sysemu/kvm.h     | 14 ++++++++++++--
>  kvm-all.c                | 15 ++++++++-------
>  kvm-stub.c               |  5 +++--
>  stubs/Makefile.objs      |  1 +
>  stubs/msi.c              | 16 ++++++++++++++++
>  target-arm/Makefile.objs |  1 +
>  target-arm/msi.c         | 16 ++++++++++++++++
>  12 files changed, 73 insertions(+), 23 deletions(-)
>  create mode 100644 stubs/msi.c
>  create mode 100644 target-arm/msi.c
> 
> -- 
> 2.4.4