All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211_rx: Remove unnecessary code
Date: Thu, 15 Oct 2015 12:20:35 +0530	[thread overview]
Message-ID: <20151015065035.GC3134@sudip-pc> (raw)
In-Reply-To: <20151014171850.GA19220@ubuntu>

On Wed, Oct 14, 2015 at 10:48:50PM +0530, Shivani Bhardwaj wrote:
> The variable frame_authorized is declared and mentioned in the code but
> is not used anywhere so, it should be removed. Also, two case statements
> are merged by removing an extra break.
<snip>
> @@ -1106,10 +1105,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
>  		switch (hostap_handle_sta_rx(ieee, dev, skb, rx_stats,
>  					     wds != NULL)) {
>  		case AP_RX_CONTINUE_NOT_AUTHORIZED:
> -			frame_authorized = 0;
> -			break;
>  		case AP_RX_CONTINUE:
> -			frame_authorized = 1;
>  			break;

Just a doubt, it now becomes:
	case AP_RX_CONTINUE_NOT_AUTHORIZED:
	case AP_RX_CONTINUE:
		break;

If these two cases are not doing anything then what is the use of having
them here in the switch-case?

regards
sudip


  reply	other threads:[~2015-10-15  6:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 17:18 [PATCH] Staging: rtl8192u: ieee80211_rx: Remove unnecessary code Shivani Bhardwaj
2015-10-15  6:50 ` Sudip Mukherjee [this message]
2015-10-15  6:52   ` [Outreachy kernel] " Shivani Bhardwaj
2015-10-15  7:01     ` Sudip Mukherjee
2015-10-15  7:07       ` Shivani Bhardwaj
2015-10-15  7:19         ` Sudip Mukherjee
2015-10-15  7:43           ` Shivani Bhardwaj
2015-10-15 16:08       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151015065035.GC3134@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.