Re: [Outreachy kernel] [PATCH v2] Staging: rtl8723au: rtw_xmit: Remove unnecessary tests

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Thu, Oct 15, 2015 at 12:39:05PM +0530, Shivani Bhardwaj wrote:
> On Thu, Oct 15, 2015 at 12:17 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Wed, Oct 14, 2015 at 04:02:56PM +0530, Shivani Bhardwaj wrote:
> >> The variables which are preceded by NULL tests on them should not be
> >> checked again.
> >> Semantic patch used:
> >> @@ expression E;
> >> statement S1, S2, S3; @@
> >> if(E==NULL) {... return ...;}
> >> else S1
> >> - if(E==NULL)
> >>   S2
> >> - else S3
> >>
> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >> ---
> >> Changes in v2:
> >>       -Correct the semantic patch and make commit message better.
> >>
> >>  drivers/staging/rtl8723au/core/rtw_xmit.c | 9 ---------
> >>  1 file changed, 9 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> >> index a4b6bb6..0ea521b 100644
> >> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> >> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> >> @@ -667,7 +667,6 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
> >>
> >>       if (pattrib->encrypt == WLAN_CIPHER_SUITE_TKIP) {
> >>               /* encode mic code */
> >> -             if (stainfo) {
> >>                       u8 null_key[16]={0x0, 0x0, 0x0, 0x0,
> >>                                        0x0, 0x0, 0x0, 0x0,
> >>                                        0x0, 0x0, 0x0, 0x0,
> >
> > Now this indention is looking wrong.
> >
> > regards
> > sudip
> Is it also supposed to be a part of the same patch or a series should be made?

same patch as that indention problem is caused as "if (stainfo) {" is
removed. But can the cocci script handle that? maybe you need to modify
the indention by hand, and mention that in the commit message.

regards
sudip