Re: [PATCH 2/3] scripts/kwbimage: Make BINARY files relative to config file

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Sascha,

On Thu, 15 Oct 2015 10:18:55 +0200, Sascha Hauer wrote:
> The BINARY files given in the config files are expected to be relative
> to the place kwbimage is called from. This is bad since it breaks where
> kwbimage is called from the build directory and not the source
> directory.
> It makes more sense to make the paths in the config files relative
> to the config files which works with out of tree builds and is also
> more what a user normally expects.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

In practice those binary.0 files are not really part of the Barebox
source code. The binary.0 file has to be extracted from a vendor U-Boot
binary prior to doing the Barebox build, so it isn't exactly part of
the "source tree".

Though I agree it is probably easier to extract them once and keep them
around in the source tree (not checked-in, of course).

Note that U-Boot now has a fully open-source implementation of this
binary.0 thing, at least for Armada XP and Armada 38x. However, it's
basically copy/pasted from the vendor U-Boot, so it's not very pretty
to look at:

 - http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/ddr/marvell
   for the DDR initialization code.

 - http://git.denx.de/?p=u-boot.git;a=tree;f=arch/arm/mach-mvebu/serdes
   for the SERDES lane initialization

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox