From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Jay Cornwall <jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH RESEND] iommu/amd: Fix BUG when faulting a PROT_NONE VMA
Date: Thu, 15 Oct 2015 16:13:31 +0200 [thread overview]
Message-ID: <20151015141331.GS27420@8bytes.org> (raw)
In-Reply-To: <0528b4ee6c9af3fa326880eb18cf13b8-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
On Wed, Oct 14, 2015 at 11:56:00AM -0500, Jay Cornwall wrote:
> On 2015-10-14 04:10, Joerg Roedel wrote:
> >Hi Jay,
> >
> >On Tue, Oct 13, 2015 at 04:52:43AM -0500, Jay Cornwall wrote:
> >>handle_mm_fault indirectly triggers a BUG in do_numa_page when given
> >>a VMA without read/write/execute access. Check this condition in
> >>do_fault.
> >>
> >>do_fault -> handle_mm_fault -> handle_pte_fault -> do_numa_page
> >>
> >> mm/memory.c
> >> 3147 static int do_numa_page(struct mm_struct *mm, struct
> >>vm_area_st...
> >> ....
> >> 3159 /* A PROT_NONE fault should not end up here */
> >> 3160 BUG_ON(!(vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE)));
> >
> >Thanks for the fix! Next time please Cc me directly on patches for AMD
> >IOMMU code, so I see your patches earlier.
> >
> >Also this looks relevant for stable, can you find out which stable
> >kernels need this fix too?
>
> Sure.
>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v4.1+
Applied, thanks.
prev parent reply other threads:[~2015-10-15 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 9:52 [PATCH RESEND] iommu/amd: Fix BUG when faulting a PROT_NONE VMA Jay Cornwall
[not found] ` <1444729963-13815-1-git-send-email-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
2015-10-14 9:10 ` Joerg Roedel
[not found] ` <20151014091015.GJ27420-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-10-14 16:56 ` Jay Cornwall
[not found] ` <0528b4ee6c9af3fa326880eb18cf13b8-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
2015-10-15 14:13 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015141331.GS27420@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.