From: Joerg Roedel <jroedel@suse.de>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Dave Young <dyoung@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@kernel.org>,
jerry_hoemann@hp.com, Jiri Kosina <jkosina@suse.cz>,
Juergen Gross <jgross@suse.com>, Mark Salter <msalter@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
WANG Chao <chaowang@redhat.com>, x86-ml <x86@kernel.org>
Subject: Re: [PATCH 0/5] x86/setup/crash: Cleanup some code
Date: Thu, 15 Oct 2015 17:33:51 +0200 [thread overview]
Message-ID: <20151015153351.GD8217@suse.de> (raw)
In-Reply-To: <1444897231-7906-1-git-send-email-bp@alien8.de>
On Thu, Oct 15, 2015 at 10:20:26AM +0200, Borislav Petkov wrote:
> this is ontop of Baoquan's fix from yesterday:
> https://lkml.kernel.org/r/20151014104338.GA8235@pd.tnic
>
> Looking at the crashkernel reservation code made a couple of style
> problems wink at me so this short cleanup should address them. Please
> take a look and complain if something's wrong.
>
> Thanks.
>
> Borislav Petkov (5):
> x86/setup: Cleanup crashkernel reservation functions
> x86/setup/crash: Remove alignment variable
> x86/setup/crash: Cleanup some more
> x86/setup/crash: Check memblock_reserve() retval
> kexec/crash: Say which char is the unrecognized
>
> arch/x86/kernel/setup.c | 81 +++++++++++++++++++++++++------------------------
> kernel/kexec_core.c | 6 ++--
> 2 files changed, 45 insertions(+), 42 deletions(-)
Looks good to me.
Reviewed-by: Joerg Roedel <jroedel@suse.de>
prev parent reply other threads:[~2015-10-15 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 8:20 [PATCH 0/5] x86/setup/crash: Cleanup some code Borislav Petkov
2015-10-15 8:20 ` [PATCH 1/5] x86/setup: Cleanup crashkernel reservation functions Borislav Petkov
2015-10-15 8:20 ` [PATCH 2/5] x86/setup/crash: Remove alignment variable Borislav Petkov
2015-10-15 8:20 ` [PATCH 3/5] x86/setup/crash: Cleanup some more Borislav Petkov
2015-10-15 8:20 ` [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval Borislav Petkov
2015-10-15 9:18 ` Dave Young
2015-10-15 10:03 ` Borislav Petkov
2015-10-15 8:20 ` [PATCH 5/5] kexec/crash: Say which char is the unrecognized Borislav Petkov
2015-10-15 9:14 ` [PATCH 0/5] x86/setup/crash: Cleanup some code Dave Young
2015-10-15 15:33 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015153351.GD8217@suse.de \
--to=jroedel@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=chaowang@redhat.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=jerry_hoemann@hp.com \
--cc=jgross@suse.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=msalter@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.