From: Oleg Nesterov <oleg@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Christoph Lameter <cl@linux.com>,
Tejun Heo <tj@kernel.org>, Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of kworker thread
Date: Thu, 15 Oct 2015 19:51:36 +0200 [thread overview]
Message-ID: <20151015175136.GA28663@redhat.com> (raw)
In-Reply-To: <20151015165309.GF12822@lerouge>
On 10/15, Frederic Weisbecker wrote:
>
> On Thu, Oct 15, 2015 at 06:32:17PM +0200, Oleg Nesterov wrote:
> >
> > But I would like to keep "we do not want to pollute current->children"
> > because this the goal of the next cleanups.
>
> I don't mind it, it's just that it's not obvious _why_ we don't want to
> pollute it.
Well, this connects to the "Note:" part of the changelog, I don't
this the comment can really explain this.
But note that this fix is not enough in the long term _unless_ we
ensure that another workueue callback can not call kernel_thread()
without CLONE_PARENT. And this is what I am going to do.
Nevermind, this is (almost) off-topic right now. Please review V2
I'll send in a minute, I tried to update the comment/changelog.
Oleg.
next prev parent reply other threads:[~2015-10-15 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 18:51 [PATCH 0/1] Revert "kmod: handle UMH_WAIT_PROC from system unbound workqueue" Oleg Nesterov
2015-10-14 18:52 ` [PATCH 1/1] " Oleg Nesterov
2015-10-15 13:37 ` Frederic Weisbecker
2015-10-15 15:18 ` Oleg Nesterov
2015-10-15 15:34 ` Frederic Weisbecker
2015-10-15 14:37 ` [PATCH 0/1] kmod: don't run async usermode helper as a child of kworker thread Oleg Nesterov
2015-10-15 14:37 ` Oleg Nesterov
2015-10-15 15:52 ` Frederic Weisbecker
2015-10-15 16:32 ` Oleg Nesterov
2015-10-15 16:53 ` Frederic Weisbecker
2015-10-15 17:51 ` Oleg Nesterov [this message]
2015-10-15 17:52 ` [PATCH v2 1/1] " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015175136.GA28663@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.