From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linaro-kernel@lists.linaro.org,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, arnd@arndb.de,
linux-pm@vger.kernel.org, linux@arm.linux.org.uk,
stern@rowland.harvard.edu
Subject: Re: [PATCH V2] debugfs: Add debugfs_create_ulong()
Date: Thu, 15 Oct 2015 11:25:55 -0700 [thread overview]
Message-ID: <20151015182555.GI4558@codeaurora.org> (raw)
In-Reply-To: <20151015071218.GD19018@linux>
On 10/15, Viresh Kumar wrote:
> On 14-10-15, 11:51, Stephen Boyd wrote:
> > On 10/09, Viresh Kumar wrote:
> > > +struct dentry *debugfs_create_xlong(const char *name, umode_t mode,
> > > + struct dentry *parent, unsigned long *value)
> > > +{
> > > + return debugfs_create_file(name, mode, parent, value, &fops_xlong);
> >
> > Were you going to refresh this on my debugfs_create_mode()
> > patches? Otherwise the patch looks fine to me.
>
> I thought you need to refresh your set as I posted this before you
> have :)
>
:)
Well this patch is creating xlong without any
read-only/write-only ops, so it has the same potential problems
as what the debugfs_create_mode() series was fixing. I'm fine
either way though.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-15 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 15:04 [PATCH] debugfs: Add debugfs_create_ulong() Viresh Kumar
2015-10-09 16:39 ` Stephen Boyd
2015-10-09 17:11 ` [PATCH V2] " Viresh Kumar
2015-10-14 18:51 ` Stephen Boyd
2015-10-15 7:12 ` Viresh Kumar
2015-10-15 18:25 ` Stephen Boyd [this message]
2015-10-18 5:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015182555.GI4558@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.