From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: socfpga: enable data/inst prefetch and shared override in the L2
Date: Thu, 15 Oct 2015 20:08:11 +0200 [thread overview]
Message-ID: <201510152008.11147.marex@denx.de> (raw)
In-Reply-To: <561FC086.6060303@opensource.altera.com>
On Thursday, October 15, 2015 at 05:04:38 PM, Dinh Nguyen wrote:
Hi!
> >>> diff --git a/arch/arm/include/asm/pl310.h
> >>> b/arch/arm/include/asm/pl310.h index 18b90b7..7a11405 100644
> >>> --- a/arch/arm/include/asm/pl310.h
> >>> +++ b/arch/arm/include/asm/pl310.h
> >>> @@ -17,6 +17,8 @@
> >>>
> >>> #define L2X0_CTRL_EN 1
> >>>
> >>> #define PL310_SHARED_ATT_OVERRIDE_ENABLE (1 << 22)
> >>>
> >>> +#define PL310_AUX_CTRL_DATA_PREFETCH_MASK (1 << 28)
> >>> +#define PL310_AUX_CTRL_INST_PREFETCH_MASK (1 << 29)
> >>
> >> These would be
> >>
> >> arch/arm/include/asm/hardware/cache-l2x0.h:#define
> >> L310_PREFETCH_CTRL_DATA_PREFETCH BIT(28)
> >> arch/arm/include/asm/hardware/cache-l2x0.h:#define
> >> L310_PREFETCH_CTRL_INSTR_PREFETCH BIT(29)
> >>
> >> ...in kernel. So maybe staying with L310_ prefix makes sense?
> >> Otherwise it looks ok.
> >
> > Why is it L... in one and PL... in the other one ? What does the "PL"
> > prefix stand for anyway ?
>
> As Pavel pointed out, it should be L310_x as this is how the Linux
> kernel is defining it. It's my mistake in the previous patch to change
> the define to PL310.
>
> I'll respin this patch with L310_PREFETCH_CTRL_DATA_PREFETCH and
> L310_PREFETCH_CTRL_INSTR_PREFETCH.
Well that didn't answer either of my questions ;-)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-10-15 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 14:59 [U-Boot] [PATCH 1/2] pl310: arm: fix up define typo for the share override bit dinguyen at opensource.altera.com
2015-10-12 14:59 ` [U-Boot] [PATCH 2/2] arm: socfpga: enable data/inst prefetch and shared override in the L2 dinguyen at opensource.altera.com
2015-10-14 16:32 ` Pavel Machek
2015-10-15 14:32 ` Marek Vasut
2015-10-15 15:04 ` Dinh Nguyen
2015-10-15 18:08 ` Marek Vasut [this message]
2015-10-15 18:18 ` Dinh Nguyen
2015-10-15 22:33 ` Marek Vasut
2015-10-14 16:31 ` [U-Boot] [PATCH 1/2] pl310: arm: fix up define typo for the share override bit Pavel Machek
2015-10-15 15:21 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510152008.11147.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.