From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] gst1-plugins-base: update configure options
Date: Thu, 15 Oct 2015 21:12:16 +0200 [thread overview]
Message-ID: <20151015211216.00df672a@gmx.net> (raw)
In-Reply-To: <20151014224011.2aac931b@free-electrons.com>
Hello Thomas,
On Wed, 14 Oct 2015 22:40:11 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Dear Peter Seiderer,
>
> On Wed, 14 Oct 2015 00:06:27 +0200, Peter Seiderer wrote:
>
> > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO_UNIX_2_0
> > + bool "gio-unix-2.0"
> > + help
> > + glib GIO unix plugin
> > +
> > endif
> > diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
> > index 08ebe03..f391530 100644
> > --- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
> > +++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
> > @@ -202,4 +202,10 @@ else
> > GST1_PLUGINS_BASE_CONF_OPTS += --disable-vorbis
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO_UNIX_2_0),y)
> > +GST1_PLUGINS_BASE_CONF_OPTS += --enable-gio_unix_2_0
> > +else
> > +GST1_PLUGINS_BASE_CONF_OPTS += --disable-gio_unix_2_0
> > +endif
>
> This is still not good I believe. You're confusing --disable-gio and
> --disable-gio_unix_2_0. According ./configure --help:
>
> --disable-gio disable dependency-less gio plugin
> --disable-gio_unix_2_0 disable glib GIO unix: gio-unix-2.0
>
> So the option that enables/disables the gio plugin (as indicated by
> your Config.in option help text) is --disable-gio.
>
> On the other hand, --disable-gio_unix_2_0 is only used for this (from
> configure.ac):
>
> dnl *** gio-unix-2.0 for tests/check/pipelines/tcp.c ***
> translit(dnm, m, l) AM_CONDITIONAL(USE_GIO_UNIX_2_0, true)
> AG_GST_CHECK_FEATURE(GIO_UNIX_2_0, [glib GIO unix], gio-unix-2.0, [
> AG_GST_PKG_CHECK_MODULES(GIO_UNIX_2_0, gio-unix-2.0 >= 2.24)
> ])
>
> So I believe we don't really care about gio_unix_2_0, it's only used
> for tests. We could just as well pass --disable-gio_unix_2_0
> unconditionally, and have an option
> BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO to enable/disable the gio
> plugin.
>
...did mostly concentrate on the 'configure --help' diff between 1.4.5 and
1.6.0 version..., but will fix it in the next patch version...
Regards,
Peter
> Thanks,
>
> Thomas
prev parent reply other threads:[~2015-10-15 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 22:06 [Buildroot] [PATCH v2] gst1-plugins-base: update configure options Peter Seiderer
2015-10-14 20:40 ` Thomas Petazzoni
2015-10-15 19:12 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015211216.00df672a@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.