From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] [PATCH] rtc: Pass the IRQF_ONESHOT flag
Date: Sat, 17 Oct 2015 01:50:37 +0200 [thread overview]
Message-ID: <20151016235037.GT3421@piout.net> (raw)
In-Reply-To: <CAJKOXPdhKTy8tvwz3FOtrQLiW=qBM86em_prGLnOr5nc_q3qFQ@mail.gmail.com>
Hi,
On 16/08/2015 at 19:54:33 +0900, Krzysztof Kozlowski wrote :
> Overall the patch is not needed, description is misleading (small
> difference between "works" and "will fail") and cocci script generates
> false positive (at least for max77686, max77802 and rtc-s5m).
>
> From another point of view, have you tested the patch on these devices?
> This introduces small functional change - the irq becomes oneshot...
>
I had a good look and they are actually all false positive apart from
isl1208 (they are all MFDs). Fabio, do you mind reworking?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2015-10-16 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 2:13 [rtc-linux] [PATCH] rtc: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-08-16 10:13 ` Krzysztof Kozlowski
2015-08-16 10:51 ` Krzysztof Kozlowski
2015-08-16 10:54 ` Krzysztof Kozlowski
2015-10-16 23:50 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016235037.GT3421@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.