From: Viresh Kumar <viresh.kumar@linaro.org>
To: Saravana Kannan <skannan@codeaurora.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 5/5] cpufreq: postfix policy directory with the first CPU in related_cpus
Date: Sat, 17 Oct 2015 09:59:07 +0530 [thread overview]
Message-ID: <20151017042907.GA19018@linux> (raw)
In-Reply-To: <56215512.1080401@codeaurora.org>
On 16-10-15, 12:50, Saravana Kannan wrote:
> In the lines that follow this code we set the
> per_cpu(cpufreq_cpu_data) to point to the new policy. But if the
> subsequent cpu->get() fails, we goto out_exit_policy. But that label
> doesn't clean up the per_cpu(cpufreq_cpu_data). So, I think we need
> another label to jump to if ->get() fails
We call cpufreq_policy_free() in that case and that does the cleanup
you are talking about.
--
viresh
next prev parent reply other threads:[~2015-10-17 4:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 16:05 [PATCH V2 0/5] cpufreq: sysfs cleanup Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to copy a mask Viresh Kumar
2015-10-15 16:05 ` Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 2/5] cpufreq: create cpu/cpufreq at boot time Viresh Kumar
2015-10-15 16:05 ` Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 3/5] cpufreq: remove cpufreq_sysfs_{create|remove}_file() Viresh Kumar
2015-10-15 16:05 ` Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories Viresh Kumar
2015-10-15 16:05 ` Viresh Kumar
2015-10-15 19:25 ` Saravana Kannan
2015-10-15 21:35 ` Rafael J. Wysocki
2015-10-16 5:51 ` Viresh Kumar
2015-10-28 8:16 ` Rafael J. Wysocki
2015-10-28 8:28 ` Viresh Kumar
2015-10-15 16:05 ` [PATCH V2 5/5] cpufreq: postfix policy directory with the first CPU in related_cpus Viresh Kumar
2015-10-15 16:05 ` Viresh Kumar
2015-10-15 19:14 ` Saravana Kannan
2015-10-16 7:08 ` Viresh Kumar
2015-10-16 7:11 ` [PATCH V3 " Viresh Kumar
2015-10-16 7:11 ` Viresh Kumar
2015-10-16 19:50 ` Saravana Kannan
2015-10-17 4:29 ` Viresh Kumar [this message]
2015-10-22 1:55 ` [PATCH V2 0/5] cpufreq: sysfs cleanup Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017042907.GA19018@linux \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.