From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbbJQGjo (ORCPT ); Sat, 17 Oct 2015 02:39:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:32869 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbbJQGjn (ORCPT ); Sat, 17 Oct 2015 02:39:43 -0400 Date: Fri, 16 Oct 2015 23:39:42 -0700 From: Greg KH To: Sergei Shtylyov Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ohci-pci: use PCI_DEVICE_SUB() Message-ID: <20151017063942.GA14187@kroah.com> References: <1541327.LNxLmfJ8uG@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1541327.LNxLmfJ8uG@wasted.cogentembedded.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 08:31:55PM +0300, Sergei Shtylyov wrote: > Toshiba Portege 4000 quirk entry can be written shorter using the > PCI_DEVICE_SUB() macro. > > Signed-off-by: Sergei Shtylyov > > --- > The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. > > drivers/usb/host/ohci-pci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > Index: usb/drivers/usb/host/ohci-pci.c > =================================================================== > --- usb.orig/drivers/usb/host/ohci-pci.c > +++ usb/drivers/usb/host/ohci-pci.c > @@ -192,10 +192,8 @@ static const struct pci_device_id ohci_p > }, > { > /* Toshiba portege 4000 */ > - .vendor = PCI_VENDOR_ID_AL, > - .device = 0x5237, > - .subvendor = PCI_VENDOR_ID_TOSHIBA, > - .subdevice = 0x0004, > + PCI_DEVICE_SUB(PCI_VENDOR_ID_AL, 0x5237, > + PCI_VENDOR_ID_TOSHIBA, 0x0004), But it's much less readable now, right? Why make this change then? sorry, greg k-h