All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Ksenija Stanojević" <ksenija.stanojevic@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/4] Staging: lustre: include: Move function prototypes
Date: Sat, 17 Oct 2015 00:16:42 -0700	[thread overview]
Message-ID: <20151017071642.GA27949@kroah.com> (raw)
In-Reply-To: <CAL7P5jLo4S91AsoYSt3FgQT1qDYwcG=43iH1R2chopjQC0gwug@mail.gmail.com>

On Sat, Oct 17, 2015 at 09:09:19AM +0200, Ksenija Stanojević wrote:
> Hi,
> 
> On Sat, Oct 17, 2015 at 7:24 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Oct 14, 2015 at 11:06:28PM +0200, Ksenija Stanojevic wrote:
> >> Function prototypes need to be declared before functions are being
> >> used.
> >
> > They do?  What problem is this patch fixing, I don't see the error...
> 
> These functions:
> 
> +struct obd_export *class_export_get(struct obd_export *exp);
> +void class_export_put(struct obd_export *exp)
> 
>  are used in macros that I changed into static inline
> functions. So if I don't move them, there will be warning: implicit
> declaration...

Ah, then you needed to say that, please be more specific, I dropped this
patch, and then the later ones failed horribly.

Please fix up and resend the series.

thanks,

greg k-h


  reply	other threads:[~2015-10-17  7:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 21:04 [PATCH 0/4]Staging: lustre: Use static inline functions instead of macros Ksenija Stanojevic
2015-10-14 21:06 ` [PATCH 1/4] Staging: lustre: include: Move function prototypes Ksenija Stanojevic
2015-10-17  5:24   ` [Outreachy kernel] " Greg KH
2015-10-17  7:09     ` Ksenija Stanojević
2015-10-17  7:16       ` Greg KH [this message]
2015-10-14 21:07 ` [PATCH 2/4] Staging: lustre: include: Convert macro class_export_lock_get into static inline function Ksenija Stanojevic
2015-10-17  5:28   ` [Outreachy kernel] " Greg KH
2015-10-17  7:10     ` Ksenija Stanojević
2015-10-14 21:08 ` [PATCH 3/4] Staging: lustre: include: Convert macro class_export_lock_put " Ksenija Stanojevic
2015-10-14 21:09 ` [PATCH 4/4] Staging: lustre: include : Remove unused macros Ksenija Stanojevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151017071642.GA27949@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.