All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 4/4] staging: lustre: remove IS_PO2 and __is_po2
Date: Sat, 17 Oct 2015 11:54:22 +0200	[thread overview]
Message-ID: <20151017095422.GA29503@waves> (raw)
In-Reply-To: <20151017052105.GA10998@kroah.com>

On Fri, Oct 16, 2015 at 10:21:05PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:07:28AM +0200, Aya Mahfouz wrote:
> > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
> > been replaced by is_power_of_2
> > 
> > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > ---
> >  drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 -------
> >  1 file changed, 7 deletions(-)
> 
> You didn't test build this patch :(

I think I'm too old for this mistake. The way kbuild tests patch sets
will cause errors for sure. It tests every patch independently and of
course the removal of IS_PO2 will cause a problem if the previous
patches were not applied.

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz

  reply	other threads:[~2015-10-17  9:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 22:03 [lustre-devel] [PATCH 0/4] Remove uses and definition of IS_PO2 Aya Mahfouz
2015-10-16 22:05 ` [lustre-devel] [PATCH 1/4] staging: lustre: ldlm_extent.c: replace IS_PO2 by is_power_of_2 Aya Mahfouz
2015-10-17  5:41   ` Greg KH
2015-10-17  9:59     ` Aya Mahfouz
2015-10-16 22:06 ` [lustre-devel] [PATCH 2/4] staging: lustre: hash.c: " Aya Mahfouz
2015-10-17  5:40   ` Greg KH
2015-10-17 10:34     ` Aya Mahfouz
2015-10-17 10:47       ` Julia Lawall
2015-10-17 13:23         ` Aya Mahfouz
2015-10-17 16:06           ` Dilger, Andreas
2015-10-16 22:06 ` [lustre-devel] [PATCH 3/4] staging: lustre: workitem.c: replace IS_PO2 with is_power_of_2 Aya Mahfouz
2015-10-17  5:40   ` Greg KH
2015-10-17 16:15     ` Dilger, Andreas
2015-10-16 22:07 ` [lustre-devel] [PATCH 4/4] staging: lustre: remove IS_PO2 and __is_po2 Aya Mahfouz
2015-10-17  0:49   ` kbuild test robot
2015-10-17  1:55   ` kbuild test robot
2015-10-17  4:53   ` kbuild test robot
2015-10-17  5:21   ` Greg KH
2015-10-17  9:54     ` Aya Mahfouz [this message]
2015-10-18 10:51     ` Aya Mahfouz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151017095422.GA29503@waves \
    --to=mahfouz.saif.elyazal@gmail.com \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.