All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Daeho Jeong <daeho.jeong@samsung.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix xfstest generic/269 double revoked buffer bug
Date: Sat, 17 Oct 2015 22:30:24 -0400	[thread overview]
Message-ID: <20151018023024.GI2678@thunk.org> (raw)
In-Reply-To: <1444868598-16188-1-git-send-email-daeho.jeong@samsung.com>

On Thu, Oct 15, 2015 at 09:23:18AM +0900, Daeho Jeong wrote:
> When you repeatly execute xfstest generic/269 with bigalloc_1k option
> enabled using the below command:
> 
> "./kvm-xfstests -c bigalloc_1k -m nodelalloc -C 1000 generic/269"
> 
> you can easily see the below bug message.
> 
> "JBD2 unexpected failure: jbd2_journal_revoke: !buffer_revoked(bh);"
> 
> This means that an already revoked buffer is erroneously revoked again
> and it is caused by doing revoke for the buffer at the wrong position
> in ext4_free_blocks(). We need to re-position the buffer revoke
> procedure for an unspecified buffer after checking the cluster boundary
> for bigalloc option. If not, some part of the cluster can be doubly
> revoked.
> 
> Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>

Thanks, applied.

						- Ted

      reply	other threads:[~2015-10-18  2:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  0:23 [PATCH] ext4: fix xfstest generic/269 double revoked buffer bug Daeho Jeong
2015-10-18  2:30 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151018023024.GI2678@thunk.org \
    --to=tytso@mit.edu \
    --cc=daeho.jeong@samsung.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.