From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd2: Fix checkpoint list cleanup
Date: Sat, 17 Oct 2015 22:42:52 -0400 [thread overview]
Message-ID: <20151018024252.GJ2678@thunk.org> (raw)
In-Reply-To: <1444053572-15671-1-git-send-email-jack@suse.com>
On Mon, Oct 05, 2015 at 03:59:32PM +0200, Jan Kara wrote:
> Unlike comments and expectation of callers journal_clean_one_cp_list()
> returned 1 not only if it freed the transaction but also if it freed
> some buffers in the transaction. That could make
> __jbd2_journal_clean_checkpoint_list() skip processing
> t_checkpoint_io_list and continue with processing the next transaction.
> This is mostly a cosmetic issue since the only result is we can
> sometimes free less memory than we could. But it's still worth fixing.
> Fix journal_clean_one_cp_list() to return 1 only if the transaction was
> really freed.
>
> Fixes: 50849db32a9f529235a84bcc84a6b8e631b1d0ec
> Signed-off-by: Jan Kara <jack@suse.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2015-10-18 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 13:59 [PATCH] jbd2: Fix checkpoint list cleanup Jan Kara
2015-10-18 2:42 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018024252.GJ2678@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.