From: Theodore Ts'o <tytso@mit.edu>
To: Andy Leiserson <andy@leiserson.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fix calculation of meta_bg descriptor backups
Date: Sun, 18 Oct 2015 00:37:29 -0400 [thread overview]
Message-ID: <20151018043729.GL2678@thunk.org> (raw)
In-Reply-To: <1444060102-8296-1-git-send-email-andy@leiserson.org>
On Mon, Oct 05, 2015 at 08:48:22AM -0700, Andy Leiserson wrote:
> "group" is the group where the backup will be placed, and is initialized
> to zero in the declaration. This meant that backups for meta_bg
> descriptors were erroneously written to group 1 and group
> (desc_per_block-1).
>
> Signed-off-by: Andy Leiserson <andy@leiserson.org>
Nice catch! I added to the commit description the following
reproduction information:
mke2fs -Fq -t ext4 -b 1024 -O ^resize_inode /tmp/foo.img 16G
truncate -s 24G /tmp/foo.img
losetup /dev/loop0 /tmp/foo.img
mount /dev/loop0 /mnt
resize2fs /dev/loop0
umount /dev/loop0
dd if=/dev/zero of=/dev/loop0 bs=1024 count=2
e2fsck -fy /dev/loop0
losetup -d /dev/loop0
Cheers,
- Ted
prev parent reply other threads:[~2015-10-18 4:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 15:48 [PATCH] fix calculation of meta_bg descriptor backups Andy Leiserson
2015-10-18 4:37 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018043729.GL2678@thunk.org \
--to=tytso@mit.edu \
--cc=andy@leiserson.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.