Re: [PATCH 1/2] cpufreq: imx: fix regulator_get error handling

[Viresh Kumar <viresh.kumar@linaro.org>]

On 18-10-15, 13:01, Heiner Kallweit wrote:
>  	arm_reg = regulator_get(cpu_dev, "arm");
> +	if (IS_ERR(arm_reg)) {
> +		ret = PTR_ERR(arm_reg);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(cpu_dev, "failed to get regulator arm\n");
> +		goto put_reg;

So you will error out even for other errors, but that wasn't the case
earlier. Are you sure this is what you want?

> +	}
> +
>  	pu_reg = regulator_get_optional(cpu_dev, "pu");

Why don't we do error checking for this as well ?

> +
>  	soc_reg = regulator_get(cpu_dev, "soc");
> -	if (IS_ERR(arm_reg) || IS_ERR(soc_reg)) {
> -		dev_err(cpu_dev, "failed to get regulators\n");
> -		ret = -ENOENT;
> +	if (IS_ERR(soc_reg)) {
> +		ret = PTR_ERR(soc_reg);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(cpu_dev, "failed to get regulator soc\n");
>  		goto put_reg;
>  	}
>  
> -- 
> 2.6.1

-- 
viresh