From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: zap nios2-generic board dir
Date: Sun, 18 Oct 2015 17:35:48 +0200 [thread overview]
Message-ID: <201510181735.48599.marex@denx.de> (raw)
In-Reply-To: <1445157392-27944-1-git-send-email-thomas@wytron.com.tw>
On Sunday, October 18, 2015 at 10:36:32 AM, Thomas Chou wrote:
> As we use device tree to control u-boot now, the generic
> board can be removed.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Hi!
> ---
> arch/nios2/Kconfig | 16 ++----
> arch/nios2/config.mk | 3 +-
> board/altera/common/cfide.c | 33 -----------
> board/altera/nios2-generic/Kconfig | 12 ----
> board/altera/nios2-generic/MAINTAINERS | 6 --
> board/altera/nios2-generic/Makefile | 10 ----
> board/altera/nios2-generic/config.mk | 12 ----
> board/altera/nios2-generic/custom_fpga.h | 89
> ------------------------------ board/altera/nios2-generic/nios2-generic.c
> | 76 ------------------------- configs/nios2-generic_defconfig
> | 2 +-
> include/configs/nios2-generic.h | 23 +++++---
> 11 files changed, 24 insertions(+), 258 deletions(-)
> delete mode 100644 board/altera/common/cfide.c
> delete mode 100644 board/altera/nios2-generic/Kconfig
> delete mode 100644 board/altera/nios2-generic/MAINTAINERS
> delete mode 100644 board/altera/nios2-generic/Makefile
> delete mode 100644 board/altera/nios2-generic/config.mk
> delete mode 100644 board/altera/nios2-generic/custom_fpga.h
> delete mode 100644 board/altera/nios2-generic/nios2-generic.c
>
> diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
> index 8ae7f6e..bb4fb2a 100644
> --- a/arch/nios2/Kconfig
> +++ b/arch/nios2/Kconfig
> @@ -4,15 +4,11 @@ menu "Nios II architecture"
> config SYS_ARCH
> default "nios2"
>
> -choice
> - prompt "Target select"
> - optional
> -
> -config TARGET_NIOS2_GENERIC
> - bool "Support nios2-generic"
> -
> -endchoice
> -
> -source "board/altera/nios2-generic/Kconfig"
> +config SYS_CONFIG_NAME
> + string "Board header file"
> + help
> + This option should contain the base name of board header file.
> + The header file include/configs/<CONFIG_SYS_CONFIG_NAME>.h
> + should be included from include/config.h.
I suspect we don't want this, since we're probing from DT. This option
should default to something like include/configs/nios2.h , no ?
> endmenu
> diff --git a/arch/nios2/config.mk b/arch/nios2/config.mk
> index 82bd887..2abad3f 100644
> --- a/arch/nios2/config.mk
> +++ b/arch/nios2/config.mk
> @@ -10,10 +10,11 @@ ifeq ($(CROSS_COMPILE),)
> CROSS_COMPILE := nios2-elf-
> endif
>
> -CONFIG_STANDALONE_LOAD_ADDR ?= 0x02000000
> +CONFIG_STANDALONE_LOAD_ADDR ?= 0xd2000000
This doesn't look like a removal of generic board ;-)
> PLATFORM_CPPFLAGS += -D__NIOS2__
> PLATFORM_CPPFLAGS += -G0
> +PLATFORM_CPPFLAGS += -mno-hw-div -mno-hw-mul
This doesn't look that way either, you might want to split this patch
into a series.
> LDFLAGS_FINAL += --gc-sections
> PLATFORM_RELFLAGS += -ffunction-sections -fdata-sections
[...]
I'm really happy to see the generic board go, thanks!
next prev parent reply other threads:[~2015-10-18 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 8:36 [U-Boot] [PATCH] nios2: zap nios2-generic board dir Thomas Chou
2015-10-18 15:35 ` Marek Vasut [this message]
2015-10-18 23:41 ` Thomas Chou
2015-10-18 23:43 ` Marek Vasut
2015-10-18 23:55 ` [U-Boot] [PATCH v2] " Thomas Chou
2015-10-23 0:18 ` Thomas Chou
2015-10-23 0:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510181735.48599.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.