From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: do not allow journal_opts for fs w/o journal
Date: Sun, 18 Oct 2015 23:57:35 -0400 [thread overview]
Message-ID: <20151019035735.GS2678@thunk.org> (raw)
In-Reply-To: <04197994-C65B-4B52-9555-795E8B0B7E7B@dilger.ca>
On Fri, Oct 09, 2015 at 02:53:39PM -0600, Andreas Dilger wrote:
> On Oct 9, 2015, at 3:09 AM, Dmitry Monakhov <dmonakhov@openvz.org> wrote:
> >
> > It is appeared that we can pass journal related mount options and such options
> > be shown in /proc/mounts
> >
> > Example:
> > #mkfs.ext4 -F /dev/vdb
> > #tune2fs -O ^has_journal /dev/vdb
> > #mount /dev/vdb /mnt/ -ocommit=20,journal_async_commit
> > #cat /proc/mounts | grep /mnt
> > /dev/vdb /mnt ext4 rw,relatime,journal_checksum,journal_async_commit,commit=20,data=ordered 0 0
> >
> > But options:"journal_checksum,journal_async_commit,commit=20,data=ordered" has
> > nothing with reality because there is no jornall at all.
>
> (typo) s/jornall/journal/
>
> but looks reasonable otherwise.
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2015-10-19 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 9:09 [PATCH 1/2] ext4: explicit mount options parsing cleanup Dmitry Monakhov
2015-10-09 9:09 ` [PATCH 2/2] ext4: do not allow journal_opts for fs w/o journal Dmitry Monakhov
2015-10-09 20:53 ` Andreas Dilger
2015-10-19 3:57 ` Theodore Ts'o [this message]
2015-10-19 3:57 ` [PATCH 1/2] ext4: explicit mount options parsing cleanup Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019035735.GS2678@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.