From: Theodore Ts'o <tytso@mit.edu>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [RFC,3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa
Date: Mon, 19 Oct 2015 00:03:30 -0400 [thread overview]
Message-ID: <20151019040330.GA9381@thunk.org> (raw)
In-Reply-To: <1442279124-7309-4-git-send-email-john.stultz@linaro.org>
On Mon, Sep 14, 2015 at 06:05:22PM -0700, John Stultz wrote:
> The ext4_fsblk_t type is a long long, which should not be used
> with abs(), as is done in ext4_mb_check_group_pa().
>
> This patch modifies ext4_mb_check_group_pa() to use abs64()
> instead.
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: linux-ext4@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2015-10-19 4:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 1:05 [RFC][PATCH 0/5] Fixes for abs() usage on 64bit values John Stultz
2015-09-15 1:05 ` [RFC][PATCH 1/5] clocksource: Fix abs() usage w/ " John Stultz
2015-10-02 20:57 ` [tip:timers/urgent] " tip-bot for John Stultz
2015-09-15 1:05 ` [RFC][PATCH 2/5] time: Fix abs() usage with 64-bit values John Stultz
2015-09-15 1:05 ` [RFC][PATCH 3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa John Stultz
2015-10-19 4:03 ` Theodore Ts'o [this message]
2015-09-15 1:05 ` [RFC][PATCH 4/5] percpu: Fix abs() usage in percpu_counter_compare() John Stultz
2015-09-15 1:05 ` [RFC][PATCH 5/5] abs(): Provide build error on passing 64bit value to abs() John Stultz
2015-09-15 5:22 ` Ingo Molnar
2015-09-15 23:52 ` Linus Torvalds
2015-09-16 12:57 ` [PATCH] kernel.h: make abs() work with 64-bit types Michal Nazarewicz
2015-09-18 3:12 ` John Stultz
2015-09-15 1:49 ` [RFC][PATCH 0/5] Fixes for abs() usage on 64bit values Tejun Heo
2015-09-15 3:27 ` John Stultz
2015-09-15 3:46 ` Tejun Heo
2015-09-15 12:09 ` Jeff Epler
2015-09-15 21:21 ` Andrew Morton
2015-09-15 22:54 ` Michal Nazarewicz
2015-09-15 5:20 ` Ingo Molnar
2015-09-15 23:43 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019040330.GA9381@thunk.org \
--to=tytso@mit.edu \
--cc=john.stultz@linaro.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.