All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [devel branch]Btrfs-convert assert at volumes.c:1846
Date: Mon, 19 Oct 2015 13:21:08 +0200	[thread overview]
Message-ID: <20151019112108.GU27761@suse.cz> (raw)
In-Reply-To: <5624B828.80405@cn.fujitsu.com>

On Mon, Oct 19, 2015 at 05:30:16PM +0800, Qu Wenruo wrote:
> Recently I'm reworking the btrfs-convert chunk allocater to make it able 
> to separate data and meta chunk.
> 
> But when I was testing, I found that, your devel branch, with the 
> following commit just fails to convert an empty ext4 filesystem:
> 
> commit 0002085c53a5ac9ad1c538bfc3e39c80891c4a1a
> Author: Zhao Lei <zhaolei@cn.fujitsu.com>
> Date:   Mon Oct 12 21:23:04 2015 +0800
> 
>      btrfs-progs: fragments: use btrfs_open_dir for btrfs-fragments command

That's the top commit, but it's not causing the breakage. I've bisected
the breakage to the patch

commit 893b7a6815a735449613afbb4040f486a4a4e1d0
Author: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date:   Wed May 13 17:15:34 2015 +0800

    btrfs-progs: Read the whole superblock instead of struct btrfs_super_block.

Looks familiar? :)

The patch caused some trouble in the past (on ppc64 machines) and I've
been holding it back due to that. The plan is to add it to 4.3 devel
branch and get it fixed before the final release, so the convert could
fail in the meantime. I'm trying to put together all pending branches
for the next release so I can't say when the convert will be fixed.

  reply	other threads:[~2015-10-19 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  9:30 [devel branch]Btrfs-convert assert at volumes.c:1846 Qu Wenruo
2015-10-19 11:21 ` David Sterba [this message]
2015-10-19 12:38   ` Qu Wenruo
2015-10-20  2:33     ` Qu Wenruo
2015-10-21 11:52       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019112108.GU27761@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.