From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbbJSSvm (ORCPT ); Mon, 19 Oct 2015 14:51:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34726 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbbJSSvk (ORCPT ); Mon, 19 Oct 2015 14:51:40 -0400 Date: Mon, 19 Oct 2015 16:51:37 -0200 From: Arnaldo Carvalho de Melo To: David Ahern Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Peter Zijlstra , Namhyung Kim , Jiri Olsa , Hitoshi Mitake , Linus Torvalds , Thomas Gleixner Subject: Re: [PATCH 06/14] perf/bench: List output formatting options on 'perf bench -h' Message-ID: <20151019185137.GE2359@redhat.com> References: <1445241870-24854-1-git-send-email-mingo@kernel.org> <1445241870-24854-7-git-send-email-mingo@kernel.org> <5624F018.9040906@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5624F018.9040906@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Oct 19, 2015 at 07:28:56AM -0600, David Ahern escreveu: > On 10/19/15 2:04 AM, Ingo Molnar wrote: > >diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c > >index 33de5d57a163..d822ee0c6003 100644 > >--- a/tools/perf/bench/mem-functions.c > >+++ b/tools/perf/bench/mem-functions.c > >@@ -273,7 +273,7 @@ static double do_memcpy_gettimeofday(const struct routine *r, size_t len) > > return (double)(((double)len * iterations) / timeval2double(&tv_diff)); > > } > > > >-int bench_mem_memcpy(int argc, const char **argv, const char *prefix __unused) > >+int bench_mem_memcpy(int argc, const char **argv, const char *prefix __maybe_unused) > > { > > struct bench_mem_info info = { > > .routines = memcpy_routines, > >@@ -361,7 +361,7 @@ static const struct routine memset_routines[] = { > > { NULL, } > > }; > > > >-int bench_mem_memset(int argc, const char **argv, const char *prefix __unused) > >+int bench_mem_memset(int argc, const char **argv, const char *prefix __maybe_unused) > > { > > struct bench_mem_info info = { > > .routines = memset_routines, > >diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c > >deleted file mode 100644 > >index 7acb9b83382c..000000000000 > >--- a/tools/perf/bench/mem-memcpy.c > >+++ /dev/null > > All of this seems like leftovers from previous patches. Right, I fixed this one at the rename point, 4/5 IIRc