From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753973AbbJSTJj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Oct 2015 15:09:39 -0400
Received: from mail-lf0-f41.google.com ([209.85.215.41]:33316 "EHLO
	mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752567AbbJSTJi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Oct 2015 15:09:38 -0400
Date: Mon, 19 Oct 2015 21:09:32 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine_str'
Message-ID: <20151019190931.GA20927@gmail.com>
References: <1445241870-24854-1-git-send-email-mingo@kernel.org>
 <1445241870-24854-9-git-send-email-mingo@kernel.org>
 <5624F176.5040801@gmail.com>
 <20151019185447.GF2359@redhat.com>
 <20151019185607.GG2359@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151019185607.GG2359@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Em Mon, Oct 19, 2015 at 04:54:47PM -0200, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Oct 19, 2015 at 07:34:46AM -0600, David Ahern escreveu:
> > > On 10/19/15 2:04 AM, Ingo Molnar wrote:
> > > >@@ -128,7 +128,7 @@ static void __bench_mem_routine(struct bench_mem_info *info, int r_idx, size_t l
> > > >  	double result_bps = 0.0;
> > > >  	u64 result_cycles = 0;
> > > >
> > > >-	printf("Routine %s (%s)\n", r->name, r->desc);
> > > >+	printf("routine %s (%s)\n", r->name, r->desc);
> > > >
> > > >  	if (bench_format == BENCH_FORMAT_DEFAULT)
> > > >  		printf("# Copying %s Bytes ...\n\n", length_str);
> > > 
> > > Seems like 'R' is more appropriate here.
> > 
> > Right, changed it.
> 
> And then, he does that on a later patch, duh.

Yeah, indeed - I messed that up: tried to introduce __unused but noticed during 
development and testing on other distros that '__unused' is way too crowded a 
namespace (various fields in random headers are named like that), so after a bit 
of a fight with those headers I changed it back to __maybe_unused ... but the 
original change slipped into the series.

Do you want me to resend the series to fix this and the other problems David and 
you noticed?

Thanks,

	Ingo