All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v2] package/nodejs: add version 4.1.2
Date: Mon, 19 Oct 2015 22:35:43 +0200	[thread overview]
Message-ID: <20151019203543.GD3651@free.fr> (raw)
In-Reply-To: <20151019223038.6346f115@free-electrons.com>

Thomas, All,

On 2015-10-19 22:30 +0200, Thomas Petazzoni spake thusly:
> On Mon, 19 Oct 2015 19:51:01 +0200, Yann E. MORIN wrote:
> > diff --git a/package/nodejs/4.1.2/0001-Remove-dependency-on-Python-bz2-module.patch b/package/nodejs/4.1.2/0001-Remove-dependency-on-Python-bz2-module.patch
> > new file mode 100644
> > index 0000000..dee8042
> > --- /dev/null
> > +++ b/package/nodejs/4.1.2/0001-Remove-dependency-on-Python-bz2-module.patch
> > @@ -0,0 +1,33 @@
> > +From 3d4817c152d6f3afddcc699949c4d1664da91e2b Mon Sep 17 00:00:00 2001
> > +From: Martin Bark <martin@barkynet.com>
> > +Date: Tue, 30 Jun 2015 09:43:11 +0100
> > +Subject: [PATCH 1/4] Remove dependency on Python bz2 module
> > +
> > +The Python bz2 module is only needed in certain cases, so only import
> > +it when needed. In the normal nodejs build, this allows to remove the
> > +dependency on this module.
> 
> Read this...

Damn...

> > +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > +[Martin: adapt to 0.12.5]
> > +Signed-off-by: Martin Bark <martin@barkynet.com>
> > +[yann.morin.1998 at free.fr: adapt to 4.1.2]
> > +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > +---
> > + deps/v8/tools/js2c.py | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/deps/v8/tools/js2c.py b/deps/v8/tools/js2c.py
> > +index 77485f6..371caf5 100755
> > +--- a/deps/v8/tools/js2c.py
> > ++++ b/deps/v8/tools/js2c.py
> > +@@ -34,7 +34,6 @@
> > + import os, re, sys, string
> > + import optparse
> > + import jsmin
> > +-import bz2
> > + import textwrap
> > + 
> > + 
> 
> ... and compare it to the patch. You're no longer importing bz2
> anywhere. Look at the same patch for 0.10 and 0.12, it is importing the
> bz2 module, just conditionally.

ACK, I'll fix that commit log.

> We should maybe also upstream our nodejs patches... But that's a
> separate work.

I can take a shot at that...

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-10-19 20:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 17:50 [Buildroot] [PATCH 0/2 v2] package/nodejs: bump version (branch yem/node) Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM Yann E. MORIN
2015-10-19 20:27   ` Thomas Petazzoni
2015-10-19 20:30     ` Yann E. MORIN
2015-10-19 20:58   ` Jörg Krause
2015-10-19 21:10     ` Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 2/2 v2] package/nodejs: add version 4.1.2 Yann E. MORIN
2015-10-19 20:30   ` Thomas Petazzoni
2015-10-19 20:35     ` Yann E. MORIN [this message]
2015-10-19 20:37       ` Thomas Petazzoni
2015-10-19 20:44         ` Yann E. MORIN
2015-10-19 21:31   ` Jörg Krause
2015-10-19 21:35     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019203543.GD3651@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.