From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Consider plane rotation when calculating stride in skl_do_mmio_flip Date: Tue, 20 Oct 2015 09:42:25 +0200 Message-ID: <20151020074225.GS13786@phenom.ffwll.local> References: <1444212083-3302-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20151019182036.GD26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 510066E772 for ; Tue, 20 Oct 2015 00:42:29 -0700 (PDT) Received: by wicfv8 with SMTP id fv8so15082236wic.0 for ; Tue, 20 Oct 2015 00:42:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20151019182036.GD26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDk6MjA6MzZQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgT2N0IDA3LCAyMDE1IGF0IDExOjAxOjIzQU0gKzAxMDAsIFR2cnRr byBVcnN1bGluIHdyb3RlOgo+ID4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPiA+IAo+ID4gUHJldmlvdXNseSByb3RhdGlvbiB3YXMgaWdub3JlZCBhbmQg d3Jvbmcgc3RyaWRlIHByb2dyYW1tZWQKPiA+IGludG8gdGhlIHBsYW5lIHJlZ2lzdGVycyByZXN1 bHRpbmcgaW4gYSBjb3JydXB0IGltYWdlIG9uIHNjcmVlbi4KPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiA+IENjOiBTb25p a2EgSmluZGFsIDxzb25pa2EuamluZGFsQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE2ICsrKysrKysrKysrKy0tLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggNTM5YzM3MzdlODIzLi42 MzI4Nzg4MTkzZTQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ID4gQEAgLTExMTI2LDkgKzExMTI2LDEwIEBAIHN0YXRpYyB2b2lkIHNrbF9kb19tbWlvX2ZsaXAo c3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2ID0gaW50ZWxfY3J0Yy0+YmFzZS5kZXY7Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiArCXN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lID0gaW50ZWxfY3J0Yy0+YmFzZS5wcmltYXJ5Owo+ID4gIAlzdHJ1Y3QgZHJtX2Zy YW1lYnVmZmVyICpmYiA9IGludGVsX2NydGMtPmJhc2UucHJpbWFyeS0+ZmI7Cj4gPiAgCWNvbnN0 IGVudW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPiA+IC0JdTMyIGN0bCwgc3RyaWRl Owo+ID4gKwl1MzIgY3RsLCBzdHJpZGUsIHRpbGVfaGVpZ2h0Owo+ID4gIAo+ID4gIAljdGwgPSBJ OTE1X1JFQUQoUExBTkVfQ1RMKHBpcGUsIDApKTsKPiA+ICAJY3RsICY9IH5QTEFORV9DVExfVElM RURfTUFTSzsKPiA+IEBAIC0xMTE1Miw5ICsxMTE1MywxNiBAQCBzdGF0aWMgdm9pZCBza2xfZG9f bW1pb19mbGlwKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+ID4gIAkgKiBUaGUgc3Ry aWRlIGlzIGVpdGhlciBleHByZXNzZWQgYXMgYSBtdWx0aXBsZSBvZiA2NCBieXRlcyBjaHVua3Mg Zm9yCj4gPiAgCSAqIGxpbmVhciBidWZmZXJzIG9yIGluIG51bWJlciBvZiB0aWxlcyBmb3IgdGls ZWQgYnVmZmVycy4KPiA+ICAJICovCj4gPiAtCXN0cmlkZSA9IGZiLT5waXRjaGVzWzBdIC8KPiA+ IC0JCSBpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGRldiwgZmItPm1vZGlmaWVyWzBdLAo+ID4g LQkJCQkJICAgZmItPnBpeGVsX2Zvcm1hdCk7Cj4gPiArCWlmIChpbnRlbF9yb3RhdGlvbl85MF9v cl8yNzAocGxhbmUtPnN0YXRlLT5yb3RhdGlvbikpIHsKPiA+ICsJCS8qIHN0cmlkZSA9IFN1cmZh Y2UgaGVpZ2h0IGluIHRpbGVzICovCj4gPiArCQl0aWxlX2hlaWdodCA9IGludGVsX3RpbGVfaGVp Z2h0KGRldiwgZmItPnBpeGVsX2Zvcm1hdCwKPiA+ICsJCQkJCQlmYi0+bW9kaWZpZXJbMF0sIDAp Owo+ID4gKwkJc3RyaWRlID0gRElWX1JPVU5EX1VQKGZiLT5oZWlnaHQsIHRpbGVfaGVpZ2h0KTsK PiA+ICsJfSBlbHNlIHsKPiA+ICsJCXN0cmlkZSA9IGZiLT5waXRjaGVzWzBdIC8KPiA+ICsJCQkJ aW50ZWxfZmJfc3RyaWRlX2FsaWdubWVudChkZXYsIGZiLT5tb2RpZmllclswXSwKPiA+ICsJCQkJ CQkJICBmYi0+cGl4ZWxfZm9ybWF0KTsKPiA+ICsJfQo+IAo+IEkgd2FzIHdvbmRlcmluZyB3aHkg d2UgYXJlIGFsbG93aW5nIHN0cmlkZSBjaGFuZ2VzIGR1cmluZyBwYWdlIGZsaXAsIGJ1dAo+IGFm dGVyIGxvb2tpbmcgYXQgdGhlIGhpc3RvcnkgaXQgc2VlbXMgd2UgYXJlIG5vdC4gVGhlIHJlYXNv biBmb3IKPiB1cGRhdGluZyB0aGUgc3RyaWRlIHJlZ2lzdGVyIGlzIHRoZSBmYWN0IHRoYXQgdGhl IHVuaXRzIHdlIHNwZWNpZnkgaXQKPiBpbiBjaGFuZ2UgYmV0d2VlbiBkaWZmZXJlbnQgdGlsaW5n IG1vZGVzIG9uIFNLTCsuIFdlIHN0aWxsIHJlamVjdCBhY3R1YWwKPiBzdHJpZGUgY2hhbmdlcyBk dXJpbmcgcGFnZSBmbGlwLCB3aGljaCBpcyBnb29kIGJlY2F1c2UgYWxsb3dpbmcgaXQgd291bGQK PiBjYXVzZSBwcm9ibGVtcyBmb3IgbXkgZmItPm9mZnNldHNbXSBzdHVmZiBzaW5jZSB0aGUgaW50 ZXJwcmV0YXRpb24gb2YgdGhlCj4gbGluZWFyIG9mZnNldCB3b3VsZCBjaGFuZ2Ugd2l0aCB0aGUg c3RyaWRlLgo+IAo+IFdlIGRvIGFsbG93IGNoYW5nZXMgdG8gdGhlIHJvdGF0ZWQgc3RyaWRlIHRo b3VnaCBzaW5jZSB3ZSBkb24ndCByZWplY3QKPiBjaGFuZ2VzIHRvIHRoZSBmYiBoZWlnaHQuIEkg dGhpbmsgSSBuZWVkIHRvIGRyYXcgc29tZSBwaWN0dXJlcyBiZWZvcmUgSQo+IGNhbiBzYXkgZm9y IHN1cmUgd2hldGhlciB0aGF0IGNhbiBjYXVzZSBwcm9ibGVtcyBvciBub3QuIEJ1dCB3ZSBjYQo+ IGxlYXZlIHRoYXQgZm9yIGFub3RoZXIgcGF0Y2ggaWYgaXQgdHVybnMgb3V0IHRvIG5lZWQgaGFu ZGxpbmcuCj4gCj4gT25lIHRoaW5nIHRoYXQncyBkb2RneSBoZXJlIGlzIHRoZSBwbGFuZS0+c3Rh dGUtPnJvdGF0aW9uIGNoZWNrLiBJCj4gdGhpbmsgY3VycmVudGx5IHdlIHdhaXQgZm9yIHBlbmRp bmcgZmxpcHMgZHVyaW5nIHRoZSBhdG9taWMgY29tbWl0Cj4gcGhhc2UgYWZ0ZXIgd2UndmUgc3dh cHBlZCB0aGUgc3RhdGUuIFNvIHRoaXMgbWF5IGVuZCB1cCB1c2luZyB0aGUKPiB3cm9uZyByb3Rh dGlvbiBzZXR0aW5nLiBJdCB3b3VsZCBiZSBhbiBldmVuIGJpZ2dlciBwcm9ibGVtIGlmIHdlCj4g YWxyZWFkeSBhbGxvd2VkIHF1ZXVlaW5nIHVwIG9yIHJlcGxhY2VpbmcgcGVuZGluZyBwbGFuZSB1 cGRhdGVzLiBJCj4gc3VwcG9zZSB0aGUgcHJpbWFyeS0+ZmIgdGhpbmcgZG9lc24ndCBzdWZmZXIg ZnJvbSB0aGlzIHByb2JsZW0gYmVjYXVzZQo+IHdlIHN3YXAgdGhhdCBwb2ludGVyIG9ubHkgYWZ0 ZXIgd2UndmUgd2FpdGVkIGZvciBwZW5kaW5nIGZsaXBzLgoKQ3VycmVudCBydWxlIGlzIHRoYXQg cGFnZWZsaXAgZG9lc24ndCBhbGxvdyBhbnkgY2hhbmdlIGluIGFueSBtZXRhZGF0YS4KVGhlcmUn cyBzb21lIG1pbm9yIGV4Y2VwdGlvbiB0aGF0IG9uIHNvbWUgcGxhdGZvcm1zIHdlIGNhbiBjaGFu Z2UgdGhlCnRpbGluZyBiZWNhdXNlIHNvbWVvbmUgYXNrZWQgZm9yIHRoYXQgc3BlY2lmaWNhbGx5 IGFuZCBpdCdzIHBvc3NpYmxlLgoKYXRvbWljIGZsaXBzIHdpbGwgYmUgYWJsZSB0byBjb3BlIHdp dGggdGhpcy4gQnV0IGZvciBsZWdhY3kgcGFnZWZsaXBzIGltbwpyZWplY3QgZXZlcnl0aGluZyBh Z2dyZXNzaXZlbHkgdGhhdCBjaGFuZ2VzIG1ldGFkYXRhIChzdHJpZGUsIHRpbGluZywKcm90YXRp b24pLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=