diff for duplicates of <20151020130004.20687.91058@quantum> diff --git a/a/1.txt b/N1/1.txt index 92593eb..cc713d0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,6 @@ Quoting Geert Uytterhoeven (2015-10-20 05:31:12) > Hi Mike, -> = - +> > On Tue, Oct 20, 2015 at 2:24 PM, Michael Turquette > <mturquette@baylibre.com> wrote: > > Quoting Geert Uytterhoeven (2015-10-16 05:49:20) @@ -10,21 +9,17 @@ Quoting Geert Uytterhoeven (2015-10-20 05:31:12) > >> + struct regmap *regmap; > >> + u32 reg, cpg_mode; > >> + -> >> + regmap =3D syscon_regmap_lookup_by_phandle(np, "renesas,modemr= -"); +> >> + regmap = syscon_regmap_lookup_by_phandle(np, "renesas,modemr"); > >> + if (IS_ERR(regmap) || -> >> + of_property_read_u32_index(np, "renesas,modemr", 1, ®) = -|| +> >> + of_property_read_u32_index(np, "renesas,modemr", 1, ®) || > >> + regmap_read(regmap, reg, &cpg_mode)) { -> >> + pr_err("%s: failed to parse renesas,modemr\n", np->ful= -l_name); +> >> + pr_err("%s: failed to parse renesas,modemr\n", np->full_name); > >> + return; > >> + } > >> + -> >> + cpg_pll_config =3D &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_m= -ode)]; +> >> + cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)]; > >> + if (!cpg_pll_config->extal_div) { -> >> + pr_err("%s: Prohibited setting (cpg_mode=3D0x%x)\n", +> >> + pr_err("%s: Prohibited setting (cpg_mode=0x%x)\n", > >> + __func__, cpg_mode); > >> + return; > >> + } @@ -35,19 +30,15 @@ ode)]; > >> + r8a7795_cpg_mssr_init); > > > > Is CLK_OF_DECLARE needed? Is it possible to make this a real -> > platform_driver =C3=A0 la drivers/clk/qcom/gcc-apq8084.c? -> = - +> > platform_driver à la drivers/clk/qcom/gcc-apq8084.c? +> > I tried making it a real platform driver, but it failed: devices that are -> part of the Clock Domain failed to get their clock (error -2, IIRC, which= - is +> part of the Clock Domain failed to get their clock (error -2, IIRC, which is > -ENOENT), and thus couldn't be instantiated. > I didn't look deeper at that time. -> = - +> > [... reading code ...] -> = - +> > Aha, this may be caused by __of_clk_get_from_provider() returning > hardcoded -ENOENT instead of propagating the error returned by > __clk_create_clk()? @@ -62,21 +53,14 @@ to have _real_ clk drivers. Regards, Mike -> = - +> > Gr{oetje,eeting}s, -> = - +> > Geert -> = - +> > -- -> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6= -8k.org -> = - -> In personal conversations with technical people, I call myself a hacker. = -But -> when I'm talking to journalists I just say "programmer" or something like= - that. +> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org +> +> In personal conversations with technical people, I call myself a hacker. But +> when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds diff --git a/a/content_digest b/N1/content_digest index 27a0ec4..5fab52e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,8 +5,7 @@ "From\0Michael Turquette <mturquette@baylibre.com>\0" "Subject\0Re: [PATCH v4 5/5] [RFC] clk: shmobile: r8a7795: Add new CPG/MSSR driver\0" "Date\0Tue, 20 Oct 2015 06:00:04 -0700\0" - "To\0Geert Uytterhoeven <geert@linux-m68k.org>" - "\0" + "To\0Geert Uytterhoeven <geert@linux-m68k.org>\0" "Cc\0Geert Uytterhoeven <geert+renesas@glider.be>" Stephen Boyd <sboyd@codeaurora.org> Laurent Pinchart <laurent.pinchart@ideasonboard.com> @@ -24,8 +23,7 @@ "b\0" "Quoting Geert Uytterhoeven (2015-10-20 05:31:12)\n" "> Hi Mike,\n" - "> =\n" - "\n" + "> \n" "> On Tue, Oct 20, 2015 at 2:24 PM, Michael Turquette\n" "> <mturquette@baylibre.com> wrote:\n" "> > Quoting Geert Uytterhoeven (2015-10-16 05:49:20)\n" @@ -34,21 +32,17 @@ "> >> + struct regmap *regmap;\n" "> >> + u32 reg, cpg_mode;\n" "> >> +\n" - "> >> + regmap =3D syscon_regmap_lookup_by_phandle(np, \"renesas,modemr=\n" - "\");\n" + "> >> + regmap = syscon_regmap_lookup_by_phandle(np, \"renesas,modemr\");\n" "> >> + if (IS_ERR(regmap) ||\n" - "> >> + of_property_read_u32_index(np, \"renesas,modemr\", 1, ®) =\n" - "||\n" + "> >> + of_property_read_u32_index(np, \"renesas,modemr\", 1, ®) ||\n" "> >> + regmap_read(regmap, reg, &cpg_mode)) {\n" - "> >> + pr_err(\"%s: failed to parse renesas,modemr\\n\", np->ful=\n" - "l_name);\n" + "> >> + pr_err(\"%s: failed to parse renesas,modemr\\n\", np->full_name);\n" "> >> + return;\n" "> >> + }\n" "> >> +\n" - "> >> + cpg_pll_config =3D &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_m=\n" - "ode)];\n" + "> >> + cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)];\n" "> >> + if (!cpg_pll_config->extal_div) {\n" - "> >> + pr_err(\"%s: Prohibited setting (cpg_mode=3D0x%x)\\n\",\n" + "> >> + pr_err(\"%s: Prohibited setting (cpg_mode=0x%x)\\n\",\n" "> >> + __func__, cpg_mode);\n" "> >> + return;\n" "> >> + }\n" @@ -59,19 +53,15 @@ "> >> + r8a7795_cpg_mssr_init);\n" "> >\n" "> > Is CLK_OF_DECLARE needed? Is it possible to make this a real\n" - "> > platform_driver =C3=A0 la drivers/clk/qcom/gcc-apq8084.c?\n" - "> =\n" - "\n" + "> > platform_driver \303\240 la drivers/clk/qcom/gcc-apq8084.c?\n" + "> \n" "> I tried making it a real platform driver, but it failed: devices that are\n" - "> part of the Clock Domain failed to get their clock (error -2, IIRC, which=\n" - " is\n" + "> part of the Clock Domain failed to get their clock (error -2, IIRC, which is\n" "> -ENOENT), and thus couldn't be instantiated.\n" "> I didn't look deeper at that time.\n" - "> =\n" - "\n" + "> \n" "> [... reading code ...]\n" - "> =\n" - "\n" + "> \n" "> Aha, this may be caused by __of_clk_get_from_provider() returning\n" "> hardcoded -ENOENT instead of propagating the error returned by\n" "> __clk_create_clk()?\n" @@ -86,23 +76,16 @@ "Regards,\n" "Mike\n" "\n" - "> =\n" - "\n" + "> \n" "> Gr{oetje,eeting}s,\n" - "> =\n" - "\n" + "> \n" "> Geert\n" - "> =\n" - "\n" + "> \n" "> --\n" - "> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=\n" - "8k.org\n" - "> =\n" - "\n" - "> In personal conversations with technical people, I call myself a hacker. =\n" - "But\n" - "> when I'm talking to journalists I just say \"programmer\" or something like=\n" - " that.\n" + "> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n" + "> \n" + "> In personal conversations with technical people, I call myself a hacker. But\n" + "> when I'm talking to journalists I just say \"programmer\" or something like that.\n" > -- Linus Torvalds -6478f3ce40d75a03d63551a89909b94ca5334d962048d2bf855cee54d7226b47 +f38a7415e6b91adfa7dd12b29701b805bb41de2840b044d51d6e12d073d27318
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.